-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Index Management to the new ES JS client #105863
Merged
cjcenizal
merged 15 commits into
elastic:master
from
cjcenizal:index-management/migrate-legacy-es-js-client
Aug 2, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dbedd4a
Migrate Index Management APIs to new ES JS client.
cjcenizal a7c8700
Migrate API integration tests.
cjcenizal 9aba111
Migrate remaining routes to handleEsError.
cjcenizal c29babf
Assorted server cleanup.
cjcenizal fead8c1
Fix or ignore TS errors.
cjcenizal 5e0ccd9
Clarify test details in CCR README. Fix typo in Index Management README.
cjcenizal a3b97c0
Merge branch 'master' into index-management/migrate-legacy-es-js-client
cjcenizal 83ce079
Update Index Management README:
cjcenizal a1b4b20
Convert data stream API helpers to use dedicated ES APIs.
cjcenizal 39bb134
Convert last isEsError remnant to handleEsError.
cjcenizal e0056d3
Remove isEsError from es_ui_shared.
cjcenizal 2651a31
Add @elastic/elasticsearch to @ts-expect-error annotations.
cjcenizal 88a2e09
Merge branch 'master' into index-management/migrate-legacy-es-js-client
cjcenizal 0ed2d64
Rebuild docs.
cjcenizal d78dacd
Merge branch 'master' into index-management/migrate-legacy-es-js-client
cjcenizal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
src/plugins/es_ui_shared/__packages_do_not_import__/errors/is_es_error.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is still open, but I moved this logic to the server because that way the API route itself is responsible for preventing bad input from being sent to ES.