Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test harness for SO migration integration tests #106116

Merged
merged 7 commits into from
Aug 9, 2021

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jul 19, 2021

Summary

This adds a new test helper for running integration tests against a fully configured Kibana instance. This utility is useful for testing migrations that have dependencies on other plugins or registry contents.

I'll be including this utility in the new Saved Object migration testing documentation.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 19, 2021
@joshdover joshdover requested a review from a team as a code owner July 19, 2021 15:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

* These tests are a little unnecessary because these migrations are incredibly simple, however
* this file serves as an example of how to use test_helpers/so_migrations.
*/
describe('ui settings migrations', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this file as an example of how to use this utility

@Bamieh
Copy link
Member

Bamieh commented Jul 22, 2021

@elasticmachine merge upstream

@joshdover joshdover requested a review from mshustov August 9, 2021 12:30
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
@joshdover joshdover enabled auto-merge (squash) August 9, 2021 14:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit f3d8431 into elastic:master Aug 9, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 9, 2021
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 9, 2021
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants