Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [RBAC] Adds bulk update route to rule registry and bulk update function to alerts client #106297

Merged
merged 9 commits into from
Aug 9, 2021
Merged

[RAC] [RBAC] Adds bulk update route to rule registry and bulk update function to alerts client #106297

merged 9 commits into from
Aug 9, 2021

Commits on Aug 9, 2021

  1. wip undo me 

    more WIP

I think this is working now

getting there..

working integration tests

fixes type check errors

fix jest

somehow this was deleted after rebasing...

fix early rejection error

ids array XOR query string in bulk update route

if ids, use elasticsearch bulk update method otherwise use update by query

fix tests

refresh true

fix tests

general cleanup

fixes apm jest test

fixes jest tests

code cleanup and fixed jest tests

WIP - trying to fix integration tests after refactor

fix tests, throw appropriate HTTP errors in alerts client

fix issues after rebasing with master

updates alerts client docs

general cleanup

fix trial integration tests

possibly fixes loader issue in package

updates getSafeSortIds param type to include 'null' in param type, renames getFindAuthorizationFilter -> getAuthorizationFilter and renames usage elsewhere, utilizes const for test in apm

make 'operation' parameter non-optional in getAuthorizationFilter and retain backwards compatibility by pointing the getFindAuthorizationFilter to getAuthorizationFilter and operation = ReadOperations.Find

adds an exported type to be used when setting a status on an alert

moves es query config out of client definition and into a function to allow for customized configurations

update by query should check for siem signals status field as well

return 200 when no alerts are found, not a 401 error, updates integration tests with stricter expects

updates alerts clients docs

fixing merge with master conflicts

adds missing required space ids field to mocked alerts to fix failing apm jest tests

implements suggested changes with auditing failures in bulk update by ids function, removes audit logging in catch blocks, cleans up other jest tests

execute ensure authorized in the search after loop, adds jest tests to make sure we log an error to the audit log for the case when ensureAuthorized throws an authorization error
    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    6706d8a View commit details
    Browse the repository at this point in the history

  2. removes duplicate import after rebase with master

    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    60e35bb View commit details
    Browse the repository at this point in the history

  3. adds more jest tests

    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    ce41d56 View commit details
    Browse the repository at this point in the history

  4. rename private functions in alerts as data client and add missing whi… 

    …tespace char to inline snapshots
    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    c3ad00f View commit details
    Browse the repository at this point in the history

  5. fixes typo from renaming

    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    d4e8164 View commit details
    Browse the repository at this point in the history

  6. update alerts as data client docs

    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    8dd966f View commit details
    Browse the repository at this point in the history

  7. use jest-specific functions instead of reaching into mock calls for e… 

    …xepcted values
    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    ba1857e View commit details
    Browse the repository at this point in the history

  8. only writes an outcome of 'success' if operation is an access operati… 

    …on, adds jest tests for when user is unauthorized to access given alert
    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    36838ab View commit details
    Browse the repository at this point in the history

  9. replaces toHaveBeenLastCalledWith with toHaveBeenNthCalledWith

    @dhurley14
    dhurley14 committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    04044f5 View commit details
    Browse the repository at this point in the history