Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Rename alertTypeRegistry to ruleTypeRegistry according to the new terminology. #106519

Merged
merged 19 commits into from
Jul 27, 2021
Merged

[Alerting] Rename alertTypeRegistry to ruleTypeRegistry according to the new terminology. #106519

merged 19 commits into from
Jul 27, 2021

Conversation

YulNaumenko
Copy link
Contributor

Summary

Follow up PR on #106382

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Jul 22, 2021
@YulNaumenko YulNaumenko self-assigned this Jul 22, 2021
@YulNaumenko YulNaumenko requested review from a team as code owners July 22, 2021 11:29
@YulNaumenko YulNaumenko requested a review from a team July 22, 2021 11:29
@YulNaumenko YulNaumenko requested a review from a team as a code owner July 22, 2021 11:29
@YulNaumenko YulNaumenko requested review from pzl and joeypoon July 22, 2021 11:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@YulNaumenko @ymao1
Apply suggestions from code review
04f9516 
Co-authored-by: ymao1 <ying.mao@elastic.co>
@darnautov
Copy link
Contributor

@YulNaumenko this PR just got merged, so you also need to update this file

@YulNaumenko YulNaumenko requested a review from ymao1 July 25, 2021 07:16
@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

weltenwort
weltenwort requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investing the effort! I noticed some changes that look like failed merge conflict resolutions in the infra plugin and commented on them below.

x-pack/plugins/infra/public/plugin.ts Outdated Show resolved Hide resolved
x-pack/plugins/infra/public/plugin.ts Show resolved Hide resolved
x-pack/plugins/triggers_actions_ui/public/types.ts Outdated Show resolved Hide resolved
@YulNaumenko
Copy link
Contributor Author

Related issue #90375

ymao1
ymao1 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One step closer to the new terminology in code! <3

justinkambic
justinkambic approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weltenwort
weltenwort approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra and observability plugin changes LGTM, thanks again!

@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB -2.0B
monitoring 730.2KB 730.2KB -2.0B
triggersActionsUi 1.6MB 1.6MB -31.0B
total -35.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 145.3KB 145.3KB -1.0B
monitoring 45.6KB 45.5KB -11.0B
observability 59.6KB 59.6KB -3.0B
stackAlerts 17.7KB 17.7KB -7.0B
triggersActionsUi 89.3KB 89.3KB -14.0B
uptime 29.3KB 29.3KB -3.0B
total -39.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit f589c2f into elastic:master Jul 27, 2021
@ymao1 ymao1 mentioned this pull request Jul 27, 2021
Merged
9 tasks
@YulNaumenko YulNaumenko mentioned this pull request Jul 28, 2021
Merged
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@YulNaumenko @ymao1
@kibanamachine @vadimkibana
[Alerting] Rename alertTypeRegistry to ruleTypeRegistry according to …
7aa9a60 
…the new terminology. (elastic#106519)

* [Alerting] Renamed Alerting framework AlertsClient to RulesClient according to the new terminology.

* fixed path

* fixed type checks

* fixed type checks

* [Alerting] Rename alertTypeRegistry to ruleTypeRegistry.

* Apply suggestions from code review

Co-authored-by: ymao1 <ying.mao@elastic.co>

* fixed type checks

* fixed tests

* fixed merge issues

* fixed merge issues

* fixed tests

* fixed tests

* fixed functional tests

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@ymao1 ymao1 ymao1 approved these changes

@darnautov darnautov darnautov approved these changes

@neptunian neptunian neptunian approved these changes

@weltenwort weltenwort weltenwort approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@YulNaumenko @elasticmachine @darnautov @kibanamachine @dgieselaar @weltenwort @neptunian @ymao1 @justinkambic