Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC][Metrics UI] Index reason field on inventory metric alerts #106842

Merged
merged 5 commits into from
Jul 28, 2021
Merged

[RAC][Metrics UI] Index reason field on inventory metric alerts #106842

merged 5 commits into from
Jul 28, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Jul 27, 2021

Summary

Closes #106513.

Replaces the generic reason field with an indexed field from the alert instance.

Before:

Screenshot 2021-07-27 at 14 18 15

After:

Screenshot 2021-07-27 at 14 22 16

@afgomez afgomez added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete v7.15.0 labels Jul 27, 2021
@afgomez afgomez requested a review from a team as a code owner July 27, 2021 12:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez changed the title Pass reason from the alert fields [RAC][Metrics UI] Index reason field on inventory metric alerts Jul 27, 2021
@mgiota mgiota self-requested a review July 28, 2021 06:45
@mgiota
Copy link
Contributor

mgiota commented Jul 28, 2021

LGTM! I verify Inventory alerts started showing up in the Observability alerts table. I just noticed that for the alerts that were generated before indexing the reason, we don't show anything. How about we show - instead?
Screenshot 2021-07-28 at 09 27 53

mgiota
mgiota reviewed Jul 28, 2021
View reviewed changes
x-pack/plugins/infra/public/alerting/inventory/rule_data_formatters.ts Outdated

const link = '/app/metrics/inventory';
const reason = fields[ALERT_REASON] ?? '';
const link = '/app/metrics/inventory'; // FIXME? Not sure if we need to do something with this link
Copy link
Contributor

@mgiota mgiota Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afgomez At the moment we link to the default inventory page. I have created an issue for metrics team to give us the option to directly link to the specific inventory item with the flyout open #106497.

@weltenwort I see I didn't create a ticket for indexing the node information (if it is a container, pod or host), since link changes accordingly. Just created this one #106958 to index the node information and construct the link accordingly.

@mgiota mgiota self-requested a review July 28, 2021 12:06
mgiota
mgiota approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afgomez
Copy link
Contributor Author

afgomez commented Jul 28, 2021

@elasticmachine merge upstream

@afgomez afgomez enabled auto-merge (squash) July 28, 2021 15:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 146.2KB 146.1KB -94.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 040cf56 into elastic:master Jul 28, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 28, 2021
@mgiota @kibanamachine
[RAC][Metrics UI] Index reason field on inventory metric alerts (el…
7aa5150 
…astic#106842)

Co-authored-by: mgiota <giota85@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 28, 2021
@kibanamachine @mgiota
[RAC][Metrics UI] Index reason field on inventory metric alerts (#1…
61905cf 
…06842) (#107061)

Co-authored-by: mgiota <giota85@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
Co-authored-by: mgiota <giota85@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mgiota @kibanamachine @vadimkibana
[RAC][Metrics UI] Index reason field on inventory metric alerts (el…
68ae614 
…astic#106842)

Co-authored-by: mgiota <giota85@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiota mgiota mgiota approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC][Metrics UI] Format reason in inventory metric executor
4 participants
@afgomez @elasticmachine @mgiota @kibanamachine