Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] do not import types from the legacy elasticsearch package #106957

Merged
merged 3 commits into from
Jul 29, 2021
Merged

[Data] do not import types from the legacy elasticsearch package #106957

merged 3 commits into from
Jul 29, 2021

Conversation

mshustov
Copy link
Contributor

Summary

Use types provided by @elastic/elasticsearch package.

@mshustov mshustov added chore v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 28, 2021
@mshustov mshustov requested a review from a team as a code owner July 28, 2021 08:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mshustov mshustov mentioned this pull request Jul 28, 2021
Closed
74 tasks
mattkime
mattkime approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 837.7KB 837.7KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 785876c into elastic:master Jul 29, 2021
@mshustov mshustov deleted the data-plugin-remove-elasticsearch-package-imports branch July 29, 2021 05:52
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2021
@mshustov @kibanamachine
[Data] do not import types from the legacy elasticsearch package (ela…
72e24b6 
…stic#106957)

* do not import types from the legacy elasticsearch package

* update docs

* cleanup data_enhanced
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 29, 2021
@kibanamachine @mshustov
[Data] do not import types from the legacy elasticsearch package (#10…
f89910e 
…6957) (#107112)

* do not import types from the legacy elasticsearch package

* update docs

* cleanup data_enhanced

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mshustov @vadimkibana
[Data] do not import types from the legacy elasticsearch package (ela…
4e3b6ca 
…stic#106957)

* do not import types from the legacy elasticsearch package

* update docs

* cleanup data_enhanced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @mattkime