Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [TGrid] Bulk actions to EuiDataGrid toolbar #107141

Merged
merged 14 commits into from
Aug 3, 2021
Merged

[RAC] [TGrid] Bulk actions to EuiDataGrid toolbar #107141

merged 14 commits into from
Aug 3, 2021

Conversation

semd
Copy link
Contributor

@semd semd commented Jul 29, 2021 •
edited
Loading

Summary

#106585

Add the bulk actions and "Select all" button to the EuiDataGrid toolbar.

no_selected

alert_selected

popover

Checklist

Delete any items that are not applicable to this PR.

@semd semd added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 labels Jul 29, 2021
@semd semd marked this pull request as ready for review July 29, 2021 19:30
@semd semd requested review from a team as code owners July 29, 2021 19:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd semd added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2021
@dhurley14 dhurley14 mentioned this pull request Jul 29, 2021
Merged
3 tasks
@semd semd requested a review from a team as a code owner July 30, 2021 10:32
jbudz
jbudz approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving limits.yml - it's not ideal but we have #105941 opened and don't want to hold up development.

@semd
Copy link
Contributor Author

semd commented Aug 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

1 similar comment
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Aug 2, 2021

@elasticmachine merge upstream

@semd semd enabled auto-merge (squash) August 3, 2021 16:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
timelines 236 240 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 490.9KB 490.9KB +20.0B
securitySolution 6.4MB 6.4MB +81.0B
timelines 244.5KB 260.9KB +16.4KB
total +16.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 298.2KB 298.2KB +8.0B
Unknown metric groups

API count

id before after diff
timelines 889 897 +8

API count missing comments

id before after diff
timelines 770 778 +8

async chunk count

id before after diff
timelines 11 12 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@semd semd merged commit b5e8db2 into elastic:master Aug 3, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 107141

@semd semd mentioned this pull request Aug 4, 2021
Merged
semd added a commit to semd/kibana that referenced this pull request Aug 4, 2021
@semd @kibanamachine
[RAC] [TGrid] Bulk actions to EuiDataGrid toolbar (elastic#107141)
41794f3 
* tGrid EuiDataGrid toolbar replace utilityBar

* tgrid new prop in observability

* types and translations fixes

* bulkActions props and encapsulation

* update limits

* code cleaning

* load lazy and remove export from public

* add memoization to bulk_actions

* icon change and test fixed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
semd added a commit that referenced this pull request Aug 4, 2021
@semd @kibanamachine
[RAC] [TGrid] Bulk actions to EuiDataGrid toolbar (#107141) (#107646)
8916d72 
* tGrid EuiDataGrid toolbar replace utilityBar

* tgrid new prop in observability

* types and translations fixes

* bulkActions props and encapsulation

* update limits

* code cleaning

* load lazy and remove export from public

* add memoization to bulk_actions

* icon change and test fixed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@semd @kibanamachine @vadimkibana
[RAC] [TGrid] Bulk actions to EuiDataGrid toolbar (elastic#107141)
88b2dd9 
* tGrid EuiDataGrid toolbar replace utilityBar

* tgrid new prop in observability

* types and translations fixes

* bulkActions props and encapsulation

* update limits

* code cleaning

* load lazy and remove export from public

* add memoization to bulk_actions

* icon change and test fixed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@michaelolo24 michaelolo24 mentioned this pull request Aug 9, 2021
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic left review comments

@angorayc angorayc angorayc approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@semd @elasticmachine @kibanamachine @jbudz @angorayc @kqualters-elastic