[Lens] Dynamic thresholds #107205
Closed
[Lens] Dynamic thresholds #107205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
…o lens/dynamic-threshold
|
@elasticmachine merge upstream |
mbondyra
reviewed
Aug 5, 2021
| options={[ | ||
| { | ||
| id: `${idPrefix}solid`, | ||
| label: 'Solid', |
There was a problem hiding this comment.
shouldn't this be i18n-ed?
| @@ -22,7 +23,7 @@ export function getSuggestions({ | |||
| // We only render metric charts for single-row queries. We require a single, numeric column. | |||
| if ( | |||
| table.isMultiRow || | |||
| keptLayerIds.length > 1 || | |||
| keptLayerIds.length !== 1 || | |||
There was a problem hiding this comment.
curious - why is this change here?
There was a problem hiding this comment.
Good point.
I made this change as a fix before introducing the better fix upstream here and forgot to restore it back
| const usedSeriesTypes = uniq(state.layers.map((layer) => layer.seriesType)); | ||
| return { | ||
| ...state, | ||
| layers: [ | ||
| ...state.layers, | ||
| newLayerState( | ||
| usedSeriesTypes.length === 1 ? usedSeriesTypes[0] : state.preferredSeriesType, | ||
| layerId | ||
| layerId, | ||
| layerType as LayerType |
There was a problem hiding this comment.
why is layerType typed as string and then here asserted here to LayerType? Cannot you just define type in types.ts file?
| return state?.layers.find(({ layerId: id }) => id === layerId)?.layerType; | ||
| }, | ||
|
|
||
| getLayerTypes(state, frame) { |
There was a problem hiding this comment.
I am not a fan of this name given that we have getLayerType that returns only type... I am thinking getLayerTypesParams or getLayerTypesGroups? Not ideal either :(
💔 Build Failed
Failed CI StepsTest FailuresJest Tests.x-pack/plugins/lens/public/editor_frame_service/editor_frame.editor_frame initialization should not render something before all datasources are initializedStandard OutStack TraceJest Tests.x-pack/plugins/lens/public/editor_frame_service/editor_frame.editor_frame initialization should initialize visualization state and render config panelStandard OutStack TraceJest Tests.x-pack/plugins/lens/public/editor_frame_service/editor_frame.editor_frame initialization should render the resulting expression using the expression rendererStandard OutStack Traceand 81 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #87551
New Layer UI
Threshold as new layer type
Thresholds can be line or area
Tasks:
ThresholdlayerTypeprop to visualization layerDuplicatedimension on threshold layer does not work properlylayerTypemigrationsChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: