[Observability] Remove outdated top_alerts route and related types

x-pack/plugins/observability/public/pages/alerts/alerts.stories.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import { StoryContext } from '@storybook/react';
 import React, { ComponentType } from 'react';
 import { __IntlProvider as IntlProvider } from '@kbn/i18n/react';
 import { MemoryRouter } from 'react-router-dom';
@@ -18,23 +17,16 @@ import {
 import { PluginContext, PluginContextValue } from '../../context/plugin_context';
 import { createObservabilityRuleTypeRegistryMock } from '../../rules/observability_rule_type_registry_mock';
 import { createCallObservabilityApi } from '../../services/call_observability_api';
-import type { ObservabilityAPIReturnType } from '../../services/call_observability_api/types';
-import { apmAlertResponseExample, dynamicIndexPattern } from './example_data';
-
-interface PageArgs {
- items: ObservabilityAPIReturnType<'GET /api/observability/rules/alerts/top'>;
-}
+import { dynamicIndexPattern } from './example_data';
 
 export default {
  title: 'app/Alerts',
  component: AlertsPage,
  decorators: [
- (Story: ComponentType, { args: { items = [] } }: StoryContext) => {
+ (Story: ComponentType) => {
  createCallObservabilityApi(({
  get: async (endpoint: string) => {
- if (endpoint === '/api/observability/rules/alerts/top') {
- return items;
- } else if (endpoint === '/api/observability/rules/alerts/dynamic_index_pattern') {
+ if (endpoint === '/api/observability/rules/alerts/dynamic_index_pattern') {
  return dynamicIndexPattern;
  }
  },
@@ -83,16 +75,12 @@ export default {
  ],
 };
 
-export function Example(_args: PageArgs) {
+export function Example() {
  return (
  <AlertsPage routeParams={{ query: { rangeFrom: 'now-15m', rangeTo: 'now', kuery: '' } }} />
  );
 }
-Example.args = {
- items: apmAlertResponseExample,
-} as PageArgs;
 
-export function EmptyState(_args: PageArgs) {
+export function EmptyState() {
  return <AlertsPage routeParams={{ query: {} }} />;
 }
-EmptyState.args = { items: [] } as PageArgs;

x-pack/plugins/observability/public/pages/alerts/alerts_flyout/alerts_flyout.stories.tsx

@@ -7,15 +7,14 @@
 
 import { ALERT_UUID } from '@kbn/rule-data-utils';
 import React, { ComponentType } from 'react';
-import type { TopAlertResponse } from '../';
 import { KibanaContextProvider } from '../../../../../../../src/plugins/kibana_react/public';
 import { PluginContext, PluginContextValue } from '../../../context/plugin_context';
 import { createObservabilityRuleTypeRegistryMock } from '../../../rules/observability_rule_type_registry_mock';
 import { apmAlertResponseExample } from '../example_data';
 import { AlertsFlyout } from './';
 
 interface Args {
- alerts: TopAlertResponse[];
+ alerts: Array<Record<string, unknown>>;
 }
 
 export default {

x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx

@@ -31,16 +31,16 @@ import {
 } from '@kbn/rule-data-utils/target/technical_field_names';
 import moment from 'moment-timezone';
 import React, { useMemo } from 'react';
-import type { TopAlert, TopAlertResponse } from '../';
+import type { TopAlert } from '../';
 import { useKibana, useUiSetting } from '../../../../../../../src/plugins/kibana_react/public';
 import { asDuration } from '../../../../common/utils/formatters';
 import type { ObservabilityRuleTypeRegistry } from '../../../rules/create_observability_rule_type_registry';
-import { decorateResponse } from '../decorate_response';
+import { parseAlert } from '../parse_alert';
 import { SeverityBadge } from '../severity_badge';
 
 type AlertsFlyoutProps = {
  alert?: TopAlert;
- alerts?: TopAlertResponse[];
+ alerts?: Array<Record<string, unknown>>;
  isInApp?: boolean;
  observabilityRuleTypeRegistry: ObservabilityRuleTypeRegistry;
  selectedAlertId?: string;
@@ -59,7 +59,8 @@ export function AlertsFlyout({
  const { http } = services;
  const prepend = http?.basePath.prepend;
  const decoratedAlerts = useMemo(() => {
- return decorateResponse(alerts ?? [], observabilityRuleTypeRegistry);
+ const parseObservabilityAlert = parseAlert(observabilityRuleTypeRegistry);
+ return (alerts ?? []).map(parseObservabilityAlert);
  }, [alerts, observabilityRuleTypeRegistry]);
 
  let alertData = alert;

x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx

@@ -9,7 +9,7 @@ import { EuiButtonIcon, EuiDataGridColumn } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import styled from 'styled-components';
 
-import React, { Suspense, useState } from 'react';
+import React, { Suspense, useMemo, useState } from 'react';
 import {
  ALERT_DURATION,
  ALERT_SEVERITY_LEVEL,
@@ -30,8 +30,8 @@ import type {
 
 import { getRenderCellValue } from './render_cell_value';
 import { usePluginContext } from '../../hooks/use_plugin_context';
-import { decorateResponse } from './decorate_response';
 import { LazyAlertsFlyout } from '../..';
+import { parseAlert } from './parse_alert';
 
 interface AlertsTableTGridProps {
  indexName: string;
@@ -122,6 +122,10 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
  const handleFlyoutClose = () => setFlyoutAlert(undefined);
  const { timelines } = useKibana<{ timelines: TimelinesUIStart }>().services;
 
+ const parseObservabilityAlert = useMemo(() => parseAlert(observabilityRuleTypeRegistry), [
+ observabilityRuleTypeRegistry,
+ ]);
+
  const leadingControlColumns = [
  {
  id: 'expand',
@@ -137,11 +141,7 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
  },
  rowCellRender: ({ data }: ActionProps) => {
  const dataFieldEs = data.reduce((acc, d) => ({ ...acc, [d.field]: d.value }), {});
- const decoratedAlerts = decorateResponse(
- [dataFieldEs] ?? [],
- observabilityRuleTypeRegistry
- );
- const alert = decoratedAlerts[0];
+ const alert = parseObservabilityAlert(dataFieldEs);
  return (
  <EuiButtonIcon
  size="s"
@@ -158,11 +158,7 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
  headerCellRender: () => null,
  rowCellRender: ({ data }: ActionProps) => {
  const dataFieldEs = data.reduce((acc, d) => ({ ...acc, [d.field]: d.value }), {});
- const decoratedAlerts = decorateResponse(
- [dataFieldEs] ?? [],
- observabilityRuleTypeRegistry
- );
- const alert = decoratedAlerts[0];
+ const alert = parseObservabilityAlert(dataFieldEs);
  return (
  <EuiButtonIcon
  size="s"

x-pack/plugins/observability/public/pages/alerts/index.tsx

@@ -15,15 +15,12 @@ import { ExperimentalBadge } from '../../components/shared/experimental_badge';
 import { useBreadcrumbs } from '../../hooks/use_breadcrumbs';
 import { usePluginContext } from '../../hooks/use_plugin_context';
 import { RouteParams } from '../../routes';
-import type { ObservabilityAPIReturnType } from '../../services/call_observability_api/types';
 import { AlertsSearchBar } from './alerts_search_bar';
 import { AlertsTableTGrid } from './alerts_table_t_grid';
 import { StatusFilter } from './status_filter';
 import { useFetcher } from '../../hooks/use_fetcher';
 import { callObservabilityApi } from '../../services/call_observability_api';
 
-export type TopAlertResponse = ObservabilityAPIReturnType<'GET /api/observability/rules/alerts/top'>[number];
-
 export interface TopAlert {
  fields: ParsedTechnicalFields;
  start: number;