Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monaco default style options #107930

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Add monaco default style options #107930

merged 3 commits into from
Aug 10, 2021

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Aug 9, 2021 •
edited
Loading

Closes #107590

  • Adds default typography options to shared Kibana Monaco CodeEditor

I didn't see much else to add, at this level, that provided us much more in terms of default styles. For the sake of consistency, the few options added by this PR do follow what is used in EUI code blocks.

The EUI team may look into establishing additional patterns for 'embedding' this component into a panel, for example, but that is not scheduled work at this point.

@ryankeairns ryankeairns requested a review from a team as a code owner August 9, 2021 16:27
@ryankeairns ryankeairns requested a review from timroes August 9, 2021 16:27
@ryankeairns ryankeairns added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Aug 9, 2021
@ryankeairns
Copy link
Contributor Author

@elasticmachine merge upstream

@ryankeairns ryankeairns force-pushed the rk/monaco-typography-styles branch from 0869abc to c5e5fde Compare August 10, 2021 18:08
@ryankeairns
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 312.1KB 312.1KB +51.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@ryankeairns ryankeairns merged commit ca2a591 into elastic:master Aug 10, 2021
@ryankeairns ryankeairns mentioned this pull request Aug 10, 2021
Merged
ryankeairns added a commit that referenced this pull request Aug 10, 2021
@ryankeairns @kibanamachine
Add monaco default style options (#107930) (#108113)
d470500 
* Add monaco default style options

* Update snapshot

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default styles for CodeEditor
3 participants
@ryankeairns @kibanamachine @poffdeluxe