Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Adds new operatorsList prop in exceptions builder to allow a list of operators #108015

Merged
merged 2 commits into from
Aug 12, 2021
Merged

[Security Solution][Endpoint] Adds new operatorsList prop in exceptions builder to allow a list of operators #108015

merged 2 commits into from
Aug 12, 2021

Conversation

dasansol92
Copy link
Contributor

Summary

  • As wee need a specific operators list for event filters and this can be something needed for future types of exceptions I added an optional prop to the exceptions builder that allows consumer to define the operators list will be displayed in the dropdown.
  • Added an operators list for event filters in list-utils package.
  • Use this operators list in event filters form in order to show just the supported operators for event filters.
  • Current components using exception builders are not affected because this change.

operatorsList

@dasansol92
Adds new operatorsList prop in exceptions builder to allow pass a lis…
dd3f887 
…t of operators. Add this prop in event filters form
@dasansol92 dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 10, 2021
@dasansol92 dasansol92 requested review from a team as code owners August 10, 2021 09:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 mentioned this pull request Aug 10, 2021
Closed
@FrankHassanabad
Copy link
Contributor

Everything looks good other than I think this should have Cypress tests or the existing ones updated to ensure this new feature works as described.

@dasansol92
Copy link
Contributor Author

Everything looks good other than I think this should have Cypress tests or the existing ones updated to ensure this new feature works as described.

Hi @FrankHassanabad , totally agree. We have a plan to implement a bunch of ftr/cypress tests on event filters but there is no one at the moment.

ashokaditya
ashokaditya reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code only. Have a minor nitpick and a question.

x-pack/plugins/lists/public/exceptions/components/builder/entry_renderer.tsx Show resolved Hide resolved
x-pack/plugins/lists/public/exceptions/components/builder/entry_renderer.tsx Show resolved Hide resolved
ashokaditya
ashokaditya approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dasansol92 dasansol92 added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 11, 2021
FrankHassanabad
FrankHassanabad approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • I briefly looked things over.
  • I kind of understand what is going on, but not strongly
  • I did not test run this, and left notes that this doesn't have tests but was given a verbal direct message that tests are coming in a follow up.

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 276.6KB 276.9KB +315.0B
securitySolution 6.5MB 6.5MB +235.0B
total +550.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 merged commit de9d784 into elastic:master Aug 12, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 12, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
@dasansol92 @kibanamachine
Adds new operatorsList prop in exceptions builder to allow pass a lis…
820296d 
…t of operators. Add this prop in event filters form (elastic#108015)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 12, 2021
@kibanamachine @dasansol92
Adds new operatorsList prop in exceptions builder to allow pass a lis…
65c551f 
…t of operators. Add this prop in event filters form (#108015) (#108349)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: David Sánchez <davidsansol92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokaditya ashokaditya ashokaditya approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@parkiino parkiino Awaiting requested review from parkiino

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dasansol92 @elasticmachine @FrankHassanabad @kibanamachine @ashokaditya