Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service inventory: Services table row height is larger than other tables #108097

Closed
wants to merge 1 commit into from
Closed

[APM] Service inventory: Services table row height is larger than other tables #108097

wants to merge 1 commit into from

Conversation

cauemarcondes
Copy link
Contributor

closes #108001

Screen Shot 2021-08-10 at 15 34 36

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 10, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner August 10, 2021 19:35
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv reviewed Aug 10, 2021
View reviewed changes
x-pack/plugins/apm/public/components/app/service_inventory/service_list/index.tsx
@@ -50,6 +50,7 @@ function formatString(value?: string | null) {
}

const ToolTipWrapper = euiStyled.span`
line-height: 0px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. This seems a bit fishy. Wouldn't be surprised if this is handled differently across browsers.

sorenlouv
sorenlouv approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotm (looks odd to me) but if it fixes the problem 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +20.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

Closing this PR since the problem was solved when I removed the TooltipWrapper on this PR 97e345f#diff-cd1f35fe0af2d6b844e6d2c7225ac0dad51c242608624cabff4cbe44b138426bL99

@cauemarcondes cauemarcondes deleted the apm-service-inventory-row-size branch August 11, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service inventory: Services table row height is larger than other tables
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv