-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Link to Add Data (Beats tutorials) when there are no integrations found #108224
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@@ -201,7 +205,7 @@ function MissingIntegrationContent({ | |||
<p> | |||
<FormattedMessage | |||
id="xpack.fleet.integrations.missing" | |||
defaultMessage="Don't see an integration? Collect any logs or metrics using our {customInputsLink}. Request new integrations using our {discussForumLink}." | |||
defaultMessage="Don't see an integration? Collect any logs or metrics using our {customInputsLink}, or set up {beatsTutorialLink}. Request new integrations using our {discussForumLink}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mostlyjason @VijayDoshi Thoughts on this copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "or add data using Beats modules"? We haven't told the user about agent or beats yet, so they might not understand the significance of calling them "individual" Beats here.
@jen-huang what do you think about changing the title of this page to "Elastic Agent Integrations"? That would make it more clear how this page differs from our add data tutorials. Once we make it a unified integrations page, we can change it back to just "Integrations". That might be too long for the sidebar menu, but there is space in the page content? We could also update the subtitle to say "Collect data from popular apps and services using Elastic Agent". |
@mostlyjason - I've made the copy updates you requested above here. |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kpollich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 Consider this comment my approval. Thanks for taking it over @kpollich!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…ions found (elastic#108224) * Link to add data/beats tutorials when there are no integrations found * Address PR feedback + fox i18n * Update integrations page subtitle Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
…ions found (elastic#108224) * Link to add data/beats tutorials when there are no integrations found * Address PR feedback + fox i18n * Update integrations page subtitle Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
…ions found (#108224) (#108520) * Link to add data/beats tutorials when there are no integrations found * Address PR feedback + fox i18n * Update integrations page subtitle Co-authored-by: Kyle Pollich <kpollich1@gmail.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com> Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
…ions found (#108224) (#108519) * Link to add data/beats tutorials when there are no integrations found * Address PR feedback + fox i18n * Update integrations page subtitle Co-authored-by: Kyle Pollich <kpollich1@gmail.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com> Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
Hi @jen-huang We have gone through the ticket and Created 02 new test-Cases and Updated 01 test-Cases. Test-Case Creation :
Test-Case Updation:
Enhancement : "Installed Elastic Agent integrations" should displayed instead of "Installed integrations" under Integrations->Manage tab for better visibility for user. Thanks!! |
@vipulsrivastava-qasource Thank you for the suggestion, but I think expanding the title there would be too long. |
Summary
Relates to #107682. This PR adds a link to Add Data tutorials directory when there are no integrations found from the user's query, in addition to the existing link for a custom input: