[XY, Pie] Long legend values support

[stratoula]

Summary

Part of #41418

• Adds two additional settings on the options tab
• The switch is by default on, and the max lines number input is enabled and set to 1.
• If the user turns off the switch, the input will be disabled and the legend items will display their whole context.
• Max truncated lines are set to 5.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[dej611]

Did a quick review check with Safari.

I found this strange bug where one legend item was not fully displayed:

I thought that one first item label was actually been stored truncated, but then opening the Inspector Panel shows me the full version:

[stratoula]

@dej611 this happens because there is another setting in the pie chart, the Truncate text which is by default 100

I think I should group these settings together somehow. Let me think about it

[stratoula]

Ok so first of all @dej611 has found a bug :)
I was using the truncate labels setting to also truncate the legends something that is wrong.
I fixed that in this PR and also I changed a bit the truncate labels setting to work only for labels that are positioned outside the chart and not inside. We had added this setting in the old implementation as all the labels were depicted outside the chart.

[stratoula]

@elasticmachine merge upstream

[stratoula]

@elasticmachine merge upstream

[mbondyra]

Hey Stratoula, while testing, I noticed the behavior is different that in Lens - if you put more than 5 lines of legend (in the picture 1000, but works for 6 too), the setting is still respected instead of trimming to 5 and changing the setting. You can also save the vis in this state, but the setting will show the red line indicating it's invalid.
Is this a bug or we want it this way for some reason?

As for the pie chart, I am not sure if this comes from this PR but there's also some problems with the legend positioning:

I'll keep investigating!

[stratoula]

@elasticmachine merge upstream

[stratoula]

@mbondyra I addressed the first two, thanx a lot!
About the last one, you have used filters and a large query, right? This is irrelevant with this PR.

On the legend actions popover we get the entire value and we display it as the popover title. Maybe we should truncate it. I will discuss it with Michael and Graham because it also happens in Lens but is still irrelevant with these changes :)
Btw, in the filters case, the user can add a custom label so this long title can be overwritten.

[mbondyra]

I think that not truncating on filters is totally fine, but let's see what Graham and Michael say. Rechecking and approving :)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 3f30a29
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
visDefaultEditor	126	127	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visTypePie	75.0KB	76.1KB	+1.0KB
visTypeXy	114.0KB	114.8KB	+812.0B
total			+1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
visDefaultEditor	34.3KB	35.6KB	+1.3KB
visTypePie	20.8KB	21.3KB	+538.0B
visTypeXy	62.5KB	63.2KB	+691.0B
total			+2.5KB

History

• 💚 Build #146481 succeeded 48a1948
• 💚 Build #145551 succeeded a8eee39
• 💛 Build #145135 was flaky 3ac0065
• 💚 Build #144842 succeeded 1b644c5
• 💔 Build #144759 failed 7a1e89f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[mbondyra]

Thank you for addressing the comments. Code LGTM. I tested it Chrome, works fine (the bits we talked about we can address later)

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.15
✅	7.x

The backport PRs will be merged automatically after passing CI.