[RAC][Security Solution] Alert table: Resolver and Cases icons to bulk action menu #108420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
WIP
stephmilovic
changed the title
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
4 tasks
|
@elasticmachine merge upstream |
48 tasks
angorayc
reviewed
Aug 13, 2021
| @@ -205,7 +206,7 @@ export const TakeActionDropdown = React.memo( | |||
| ecsRowData: ecsData, | |||
| useInsertTimeline: insertTimelineHook, | |||
| casePermissions, | |||
| appId: 'securitySolution', | |||
| appId: APP_ID, | |||
angorayc
approved these changes
Aug 13, 2021
stephmilovic
commented
Aug 16, 2021
| @@ -134,41 +134,6 @@ describe('EventColumnView', () => { | |||
| expect(wrapper.find('[data-test-subj="pin"]').exists()).toBe(false); | |||
| }); | |||
|
|
|||
| test('it render AddToCaseAction if timelineId === TimelineId.detectionsPage', () => { | |||
There was a problem hiding this comment.
moved to .../detections/components/alerts_table/timeline_actions/alert_context_menu.test.tsx
stephmilovic
commented
Aug 16, 2021
| @@ -246,56 +245,6 @@ describe('helpers', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('isInvestigateInResolverActionEnabled', () => { | |||
There was a problem hiding this comment.
moved to .../detections/components/alerts_table/timeline_actions/investigate_in_resolver.test.tsx
stephmilovic
commented
Aug 16, 2021
| @@ -129,51 +123,6 @@ export const getEventType = (event: Ecs): Omit<TimelineEventsType, 'all'> => { | |||
| return 'raw'; | |||
| }; | |||
|
|
|||
| export const isInvestigateInResolverActionEnabled = (ecsData?: Ecs) => | |||
There was a problem hiding this comment.
moved to .../detections/components/alerts_table/timeline_actions/investigate_in_resolver.tsx
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Aug 17, 2021
stephmilovic
added a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #107917
Resolver and Cases alert table icons moved to
...overflow menu. Disabled action items are hidden.Before:
After
in alerts table:
in timeline:
in events viewer. this hasnt changed, but once those 4 top icons in the header move we will need to check the sizing of the column in this instance
