Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [RAC][Security Solution] Add to case actions in detail flyout (#108057) #108422

Merged

Conversation

kqualters-elastic
Copy link
Contributor

Backports the following commits to 7.x:

…c#108057)

* add to case action in flyout

* Fix most type errors

* Use context menu item instead of empty button for popover items

* Remove unused import

* Fire action on case modal close

* Update tests to use both components and remove console.log

* Update mocks in unit tests

* Use an onClose prop instead of closeCallbacks

* Pr feedback, create shared mock and rename handler

* Make app usable when timelines is not enabled

* Remove unused translations
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2361 2362 +1
timelines 242 246 +4
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 579.7KB 579.7KB +44.0B
securitySolution 6.5MB 6.5MB +1.2KB
timelines 267.7KB 308.7KB +41.0KB
total +42.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 306.8KB 309.5KB +2.8KB
Unknown metric groups

API count

id before after diff
cases 451 452 +1
timelines 930 936 +6
total +7

API count missing comments

id before after diff
cases 409 410 +1
timelines 810 816 +6
total +7

async chunk count

id before after diff
timelines 12 15 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit af31e3b into elastic:7.x Aug 12, 2021
@kqualters-elastic kqualters-elastic deleted the backport/7.x/pr-108057 branch August 12, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants