Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Observability] Remove outdated top_alerts route and related types (#107579) #108452

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…lastic#107579)

* Remove outdated top_alerts route and related types

* Remove tests for deleted code

* Remove test for deleted API

* Remove reference to deleted type

* Remove unused translations

* Remove unused mock from story

* Remove no-op alerts page story for now

* Remove unsafe type assertions

* Factor out alert field type

* Compile kbn-io-ts-utils for the browser as well

* Avoid deep import which doesn't work cross-platform

* Revert "Avoid deep import which doesn't work cross-platform"

This reverts commit 492378c.

* Revert "Compile kbn-io-ts-utils for the browser as well"

This reverts commit a1267b1.

* Revert "Factor out alert field type"

This reverts commit def6987.

* Revert "Remove unsafe type assertions"

This reverts commit c88d4cd.

* Remove unsafe type assertions (again)
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 508.7KB 508.9KB +160.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@kibanamachine kibanamachine merged commit bc1b71a into elastic:7.x Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants