Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] [Security Solution] Improve security alerts t-grid loading and empty state #108527

Merged

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Aug 13, 2021

Summary

issue: #108069

  • Add a loading bar to the alerts table.
  • Add an empty state message when no alerts are returned.
  • No changes to the initial loading state

Query loading state

2021-08-13T12-33-24D0-19

Empty state

Screenshot 2021-08-13 at 14 38 05

Initial loading state

Screenshot 2021-08-12 at 16 00 47

Checklist

@machadoum machadoum added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 labels Aug 13, 2021
@machadoum machadoum requested a review from a team as a code owner August 13, 2021 12:52
@machadoum machadoum self-assigned this Aug 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum machadoum requested a review from a team August 13, 2021 12:54
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One tiny change of the heading size.

We may need to open a follow-up PR once the styling of the page is finalized. I'm not sure how the loading bar will coincide with the blocks above since we will be removing the padding/shadow around the table.

@machadoum machadoum force-pushed the security-rac-alerts-issue-108069 branch from c5f9959 to af71d02 Compare August 13, 2021 14:37
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@michaelolo24
Copy link
Contributor

michaelolo24 commented Aug 14, 2021

@machadoum Tested locally, and it all works great! Just two things. Can you please remove the Additional Filters button too when no data shows up? And add just a simple test that the panel with the "no results match" should show when there's no data in the table? Thanks!

@michaelolo24
Copy link
Contributor

Also @mdefazio, did we want to keep the Loading Alerts string at the bottom of the table?

@machadoum machadoum force-pushed the security-rac-alerts-issue-108069 branch from af71d02 to ddaaee7 Compare August 16, 2021 07:53
@machadoum machadoum enabled auto-merge (squash) August 16, 2021 08:12
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 400.4KB 401.4KB +1.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit c2d5d1b into elastic:master Aug 16, 2021
@mdefazio
Copy link
Contributor

Are you referring to this?
image

This appears to be loading in the same block as the pagination? I don't think we need this if we have the loading indicators on top of the table are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants