[5.x] [UI Framework] Create Button React components in UI Framework. #10939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #10646 **Commit 1:** Create Button React components in UI Framework. * Original sha: 68e14a2 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-02T03:43:14Z **Commit 2:** Integrate button icon variations into button_icon.js. Integrate button variations inbot button.js. - Rename classes prop to className. * Original sha: efa0a26 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-02T17:26:16Z **Commit 3:** Add KuiLoadingButtonIcon and isLoading prop for KuiButton. * Original sha: c55ff13 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-02T19:11:52Z **Commit 4:** Add Jest test coverage for UI Framework. - Add tests for KuiButton. - Generate report in ui_framework/jest/report. * Original sha: b461275 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-21T01:17:29Z **Commit 5:** Add tests for KuiButtonIcon and KuiButtonGroup. * Original sha: 933f8ec * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-21T18:20:57Z **Commit 6:** Add both React and HTML examples for KuiButton. * Original sha: 36e0ea6 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-21T20:52:04Z **Commit 7:** Update UI Framework README with instructions on creating and testing React components. * Original sha: 802f1ea * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-21T23:52:29Z **Commit 8:** Move KuiButton isDisabled check from onClick handler to prop assginment. * Original sha: 0132a55 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-21T23:58:34Z **Commit 9:** Refactor kuiButton to not use createElement, and instead exit early and return the correct element. * Original sha: 31219b3 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T00:10:03Z **Commit 10:** Redesign KuiButton and KuiButtonIcon to accept a type prop. * Original sha: a8000c9 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T04:13:29Z **Commit 11:** Break KuiButton apart into KuiButton, KuiLinkButton, and KuiSubmitButton. * Original sha: 020d94c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T04:53:36Z **Commit 12:** Move KuiButtonIcon and KuiButtonGroup into their own directories. * Original sha: 119abf5 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T05:01:59Z **Commit 13:** Remove unused icon var from KuiSubmitButton. * Original sha: 24a9a4f * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T05:05:32Z **Commit 14:** Use simpler rest parameter syntax instead of Object.assign for defining KuiButton propTypes. * Original sha: 4119bfb * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T18:42:31Z **Commit 15:** Refactor KuiButton and KuiButtonIcon type prop to emphasize passing string literals instead of enums. * Original sha: d50d081 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T19:06:42Z **Commit 16:** Add comment to explain role of nonVoidPropTypes in KuiButton. * Original sha: f9c55fa * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T19:15:57Z **Commit 17:** Dynamically define KuiButton and KuiButtonIcon tests for type prop. * Original sha: 0c5d2fd * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T20:46:17Z **Commit 18:** Fix Jest coverage configuration for deeply-nested dirs. * Original sha: 6d724fc * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T21:27:30Z **Commit 19:** Rename prop testSubject to data-test-subj. * Original sha: a9a4652 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-22T22:22:51Z **Commit 20:** button idea * Original sha: d1eed94 * Authored by Kim Joar Bekkelund <kjbekkelund@gmail.com> on 2017-03-23T12:57:03Z * Committed by CJ Cenizal <cj@cenizal.com> on 2017-03-28T15:21:03Z **Commit 21:** Remove unnecessary onClick mentions * Original sha: a2d045e * Authored by Kim Joar Bekkelund <kjbekkelund@gmail.com> on 2017-03-23T15:36:34Z * Committed by CJ Cenizal <cj@cenizal.com> on 2017-03-28T15:21:03Z **Commit 22:** - Update KuiLinkButton to preventDefault on click when disabled. - Update getClassName helper to accommodate loading icons. - Update tests. * Original sha: 4016eba * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T00:45:00Z **Commit 23:** Update tests with HTML attributes group. Add test for aria-label. * Original sha: 05d934b * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T17:08:29Z **Commit 24:** Add UI Framework to linting task. * Original sha: 3bc5016 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T17:24:41Z **Commit 25:** Refactor HTML attribute tests to be more succinct. * Original sha: 322a968 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T18:58:45Z **Commit 26:** Remove backticks from ui_framework_test task. * Original sha: 2187260 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T19:00:24Z **Commit 27:** Add eslintrc file to ui_framework, for Jest-specific rules. * Original sha: 94daf03 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T19:06:42Z **Commit 28:** Add UI Framework Jest tests to npm test script. Create separate scripts for watching and generating coverage reports. * Original sha: 2fa3cf7 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T20:58:00Z **Commit 29:** Remove redundant kuiSubmitButton tests. * Original sha: 8d4222a * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T21:06:13Z **Commit 30:** Document Enzyme-specific Webpack configuration. * Original sha: ad9616f * Authored by CJ Cenizal <cj@cenizal.com> on 2017-03-24T21:09:07Z
cjcenizal
force-pushed
the
jasper/backport/10646/5.x
branch
from
4453e73 to
70125d2
Compare
|
It looks like this backport is actually missing changes from the original. Closing and going to try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[UI Framework] Create Button React components in UI Framework.
Backports PR #10646
Commit 1:
Create Button React components in UI Framework.
Commit 2:
Integrate button icon variations into button_icon.js. Integrate button variations inbot button.js.
Commit 3:
Add KuiLoadingButtonIcon and isLoading prop for KuiButton.
Commit 4:
Add Jest test coverage for UI Framework.
Commit 5:
Add tests for KuiButtonIcon and KuiButtonGroup.
Commit 6:
Add both React and HTML examples for KuiButton.
Commit 7:
Update UI Framework README with instructions on creating and testing React components.
Commit 8:
Move KuiButton isDisabled check from onClick handler to prop assginment.
Commit 9:
Refactor kuiButton to not use createElement, and instead exit early and return the correct element.
Commit 10:
Redesign KuiButton and KuiButtonIcon to accept a type prop.
Commit 11:
Break KuiButton apart into KuiButton, KuiLinkButton, and KuiSubmitButton.
Commit 12:
Move KuiButtonIcon and KuiButtonGroup into their own directories.
Commit 13:
Remove unused icon var from KuiSubmitButton.
Commit 14:
Use simpler rest parameter syntax instead of Object.assign for defining KuiButton propTypes.
Commit 15:
Refactor KuiButton and KuiButtonIcon type prop to emphasize passing string literals instead of enums.
Commit 16:
Add comment to explain role of nonVoidPropTypes in KuiButton.
Commit 17:
Dynamically define KuiButton and KuiButtonIcon tests for type prop.
Commit 18:
Fix Jest coverage configuration for deeply-nested dirs.
Commit 19:
Rename prop testSubject to data-test-subj.
Commit 20:
button idea
Commit 21:
Remove unnecessary onClick mentions
Commit 22:
Commit 23:
Update tests with HTML attributes group. Add test for aria-label.
Commit 24:
Add UI Framework to linting task.
Commit 25:
Refactor HTML attribute tests to be more succinct.
Commit 26:
Remove backticks from ui_framework_test task.
Commit 27:
Add eslintrc file to ui_framework, for Jest-specific rules.
Commit 28:
Add UI Framework Jest tests to npm test script. Create separate scripts for watching and generating coverage reports.
Commit 29:
Remove redundant kuiSubmitButton tests.
Commit 30:
Document Enzyme-specific Webpack configuration.