[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

YulNaumenko · 2021-08-24T01:55:57Z

Summary

Resolves #107083

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-08-24T04:01:37Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1

Some of the work is covered in this PR: #108964 and can be removed.

x-pack/plugins/actions/server/saved_objects/migrations.ts

x-pack/plugins/actions/server/saved_objects/action_task_params_migrations.ts

jportner · 2021-08-26T15:47:51Z

x-pack/plugins/actions/server/saved_objects/index.ts

@@ -35,7 +35,8 @@ export function setupSavedObjects(
  savedObjects.registerType({
    name: ACTION_SAVED_OBJECT_TYPE,
    hidden: true,
-    namespaceType: 'single',
+    namespaceType: 'multiple-isolated',
+    convertToMultiNamespaceTypeVersion: '8.0.0',
    mappings: mappings.action as SavedObjectsTypeMappingDefinition,
    migrations: getActionsMigrations(encryptedSavedObjects),


I think you need to add a no-op migration for the ACTION_SAVED_OBJECT_TYPE type too, right?

Ah.., I forgot about this. Thank you for pointing!

jportner

I added comments for a couple of nits, overall LGTM!

I checked and it appears there are already end-to-end integration tests for migrating actions and testing to ensure secrets are decrypted properly (x-pack/test/alerting_api_integration/spaces_only/tests/actions/migrations.ts), that's why CI was failing before you added the no-op migration for actions 😄
So, assuming CI passes now, those migration tests are 👍

IMO, you don't need to add a specific 8.0.0 migration integration test, but you could optionally add a comment in that file mentioning that the conversion is getting tested implicitly by virtue of the secret getting decrypted properly.

There are also end-to-end integration test for migrating action_task_params (x-pack/test/alerting_api_integration/spaces_only/tests/action_task_params/migrations.ts), but the data in the fixtures doesn't actually include any encrypted attributes. That's an area for possible improvement in the future, but is outside the scope of this PR, IMO.

x-pack/plugins/actions/server/saved_objects/action_task_params_migrations.test.ts

x-pack/plugins/actions/server/saved_objects/actions_migrations.test.ts

chrisronline

LGTM!

ymao1

LGTM when failing unit test is resolved

kibanamachine · 2021-08-26T23:59:58Z

💚 Build Succeeded

History

💔 Build #149012 failed 44c815d
💔 Build #148979 failed 2d711f8
💔 Build #148802 failed 58da525
💔 Build #148799 failed afe7ad9
💔 Build #148794 failed 92f9a77c0371ffa262ed23dbbcda0f12e76b94db

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

* [Alerting] [8.0] Prepare for making alerting saved objects sharecapable (#109990) * [Alerting] [8.0] Prepare for making alerting saved objects sharecapable * removed v8 check * removed link * added no op migration * fixed name Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Actions] [8.0] Prepare for making action saved objects sharecapable. (#109756) * [Actions] [8.0] Prepare for making action saved objects sharecapable. * added more tests * made it compatible to merge to 7.x * fixed due to comments * fixed tests * added tests * fixed tests * fixed due to comments * added no-opactions migration * fixed test * [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types (#109180) * [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types * fixed due to comments * fixed typo * added more tests * added unit test * added func test * added func tests * fixed test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * fixed merge * fixed legacy tests * fixed tests * fixed eslint * Update migrations.ts fixed action task * fixed due to comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

YulNaumenko self-assigned this Aug 24, 2021

YulNaumenko added Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 24, 2021

YulNaumenko changed the base branch from master to prepare-alerting-so-to-sharecapable August 24, 2021 03:58

YulNaumenko changed the base branch from prepare-alerting-so-to-sharecapable to master August 24, 2021 04:00

YulNaumenko marked this pull request as ready for review August 24, 2021 04:01

YulNaumenko requested a review from a team as a code owner August 24, 2021 04:01

ymao1 reviewed Aug 24, 2021

View reviewed changes

x-pack/plugins/actions/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved

x-pack/plugins/actions/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved

YulNaumenko changed the base branch from master to prepare-alerting-so-to-sharecapable August 25, 2021 23:22

YulNaumenko requested a review from a team as a code owner August 25, 2021 23:22

YulNaumenko requested a review from a team August 25, 2021 23:22

YulNaumenko requested a review from a team as a code owner August 25, 2021 23:22

YulNaumenko requested a review from a team August 25, 2021 23:22

YulNaumenko requested review from a team as code owners August 25, 2021 23:22

YulNaumenko requested a review from a team August 25, 2021 23:22

YulNaumenko requested review from a team as code owners August 25, 2021 23:22

YulNaumenko requested a review from a team August 25, 2021 23:22

YulNaumenko requested review from ymao1 and removed request for a team, academo and parkiino August 25, 2021 23:22

YulNaumenko added 6 commits August 25, 2021 19:35

[Actions] [8.0] Prepare for making action saved objects sharecapable.

4a556ec

added more tests

90f2a96

made it compatible to merge to 7.x

1e87821

fixed due to comments

e75c6a8

fixed tests

dd1b861

added tests

afe7ad9

YulNaumenko force-pushed the actions-prepare-to-sharecapable branch from 92f9a77 to afe7ad9 Compare August 26, 2021 03:30

YulNaumenko changed the base branch from master to prepare-alerting-so-to-sharecapable August 26, 2021 03:31

YulNaumenko added 2 commits August 25, 2021 20:46

Merge remote-tracking branch upstream/master

4b7e5dd

fixed tests

58da525

ymao1 requested changes Aug 26, 2021

View reviewed changes

x-pack/plugins/actions/server/saved_objects/action_task_params_migrations.ts Outdated Show resolved Hide resolved

fixed due to comments

2d711f8

YulNaumenko requested review from ymao1, jportner and mikecote August 26, 2021 15:39

jportner reviewed Aug 26, 2021

View reviewed changes

added no-opactions migration

44c815d

YulNaumenko requested a review from jportner August 26, 2021 16:55

jportner approved these changes Aug 26, 2021

View reviewed changes

x-pack/plugins/actions/server/saved_objects/action_task_params_migrations.test.ts Outdated Show resolved Hide resolved

x-pack/plugins/actions/server/saved_objects/actions_migrations.test.ts Outdated Show resolved Hide resolved

chrisronline approved these changes Aug 26, 2021

View reviewed changes

ymao1 approved these changes Aug 26, 2021

View reviewed changes

fixed test

1786b9b

YulNaumenko merged commit 2e28730 into elastic:prepare-alerting-so-to-sharecapable Aug 27, 2021

YulNaumenko mentioned this pull request Aug 27, 2021

[Alerting][8.0] Prepare alerting SOs to sharecapable #110386

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

YulNaumenko commented Aug 24, 2021 •

edited

Loading

elasticmachine commented Aug 24, 2021

ymao1 left a comment

jportner Aug 26, 2021

YulNaumenko Aug 26, 2021

jportner left a comment

chrisronline left a comment

ymao1 left a comment

kibanamachine commented Aug 26, 2021

[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

Conversation

YulNaumenko commented Aug 24, 2021 • edited Loading

Summary

elasticmachine commented Aug 24, 2021

ymao1 left a comment

Choose a reason for hiding this comment

jportner Aug 26, 2021

Choose a reason for hiding this comment

YulNaumenko Aug 26, 2021

Choose a reason for hiding this comment

jportner left a comment

Choose a reason for hiding this comment

chrisronline left a comment

Choose a reason for hiding this comment

ymao1 left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 26, 2021

💚 Build Succeeded

History

YulNaumenko commented Aug 24, 2021 •

edited

Loading