[metricVis] Add support for html field formatters #11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Feature:Visualizations
|
nice! can you add a test for this ? |
|
I'm not familiar with this field formatter. We were just trying to find it in the visualizations sync and couldn't, for what field types is it available? |
|
@ppisljar @thomasneirynck tests written and passing |
spalger
force-pushed
the
fix/html-in-metric-vis
branch
from
f9416cc to
7d857f1
Compare
|
jenkins, test this |
| @@ -1,6 +1,6 @@ | |||
| <div ng-controller="KbnMetricVisController" class="metric-vis"> | |||
| <div class="metric-container" ng-repeat="metric in metrics"> | |||
| <div class="metric-value" ng-style="{'font-size': vis.params.fontSize+'pt'}">{{metric.value}}</div> | |||
| <div class="metric-value" ng-bind-html="metric.value" ng-style="{'font-size': vis.params.fontSize+'pt'}"></div> | |||
| import ngMock from 'ng_mock'; | ||
| import expect from 'expect.js'; | ||
|
|
||
| import VisProvider from 'ui/vis'; |
There was a problem hiding this comment.
likely named import here
import {VisProvider}
is reason of failing test
thomasneirynck
approved these changes
May 11, 2017
spalger
changed the title
spalger
added a commit
that referenced
this pull request
May 12, 2017
* [metricVis] Fix html support * [metric_vis] add test to verify 42d11b021 * [ui/vis] fix import (cherry picked from commit 34c33f3)
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 19, 2017
* [metricVis] Fix html support * [metric_vis] add test to verify 42d11b021 * [ui/vis] fix import (cherry picked from commit 34c33f3)
spalger
added a commit
that referenced
this pull request
May 19, 2017
* [fieldFormat] make formatted output non-bindable (#11911) * [fieldFormat] make formatted output non-bindable * [aggTable] totals are consumed as text, produce text * [tests] fix existing tests * [fieldFormat/contentType] add tests for non-bindable wrapper (cherry picked from commit 1d2341f) * fix import statement * [metricVis] Fix html support (#11008) * [metricVis] Fix html support * [metric_vis] add test to verify 42d11b021 * [ui/vis] fix import (cherry picked from commit 34c33f3) * fix import statement
spalger
added a commit
that referenced
this pull request
May 19, 2017
* [fieldFormat] make formatted output non-bindable (#11911) * [fieldFormat] make formatted output non-bindable * [aggTable] totals are consumed as text, produce text * [tests] fix existing tests * [fieldFormat/contentType] add tests for non-bindable wrapper (cherry picked from commit 1d2341f) (cherry picked from commit f85570d) * fix import statement * [metricVis] Fix html support (#11008) * [metricVis] Fix html support * [metric_vis] add test to verify 42d11b021 * [ui/vis] fix import (cherry picked from commit 34c33f3) (cherry picked from commit eea7622) * fix import statement (cherry picked from commit 07d9a3b)
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* [metricVis] Fix html support * [metric_vis] add test to verify 42d11b021 * [ui/vis] fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric vis uses the
htmloutput of the field formatter, but doesn't render the value as html. This allows: