Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/securitysolution-io-ts-types to babel transpiler #110097

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 25, 2021

One step forward on #69706

That PR moves the @kbn/securitysolution-io-ts-types from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.1 labels Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from a team as a code owner August 25, 2021 17:51
@mistic mistic added v7.14.2 and removed v7.14.1 labels Aug 25, 2021
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic
Copy link
Member Author

mistic commented Aug 25, 2021

@tylersmalley as we discussed offline I suspect those packages are missing browser targets. Will follow that lead and see how it ends

@mistic
Copy link
Member Author

mistic commented Aug 25, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Aug 26, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 295.7KB 292.6KB -3.1KB
securitySolution 6.5MB 6.5MB -87.0B
total -3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 212.4KB 209.4KB -3.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked it over and it looks like the others 👍

@mistic mistic merged commit 24575c3 into elastic:master Aug 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 110097

mistic added a commit to mistic/kibana that referenced this pull request Aug 26, 2021
…er (elastic#110097)

* chore(NA): moving @kbn/securitysolution-io-ts-types to babel transpiler

* chore(NA): update limits

* chore(NA): update limits file

* chore(NA): introduce web bundles

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
mistic added a commit that referenced this pull request Aug 26, 2021
…er (#110097) (#110322)

* chore(NA): moving @kbn/securitysolution-io-ts-types to babel transpiler

* chore(NA): update limits

* chore(NA): update limits file

* chore(NA): introduce web bundles

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants