Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Don't ignore "index: false" in integration index template #110234

Merged
merged 2 commits into from
Aug 26, 2021
Merged

[Fleet] Don't ignore "index: false" in integration index template #110234

merged 2 commits into from
Aug 26, 2021

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Aug 26, 2021

Summary

Fixes #109764

If an integration had index set to false in an index template then it was being ignored.

Checklist

@hop-dev hop-dev added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 26, 2021
@hop-dev hop-dev requested a review from a team as a code owner August 26, 2021 13:29
@hop-dev hop-dev self-assigned this Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev hop-dev changed the title [Fleet] Don't ignore "index: false" in index template [Fleet] Don't ignore "index: false" in integration index template Aug 26, 2021
kpollich
kpollich approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hop-dev hop-dev enabled auto-merge (squash) August 26, 2021 14:43
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 2a05ec9 into elastic:master Aug 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2021
@hop-dev @kibanamachine
[Fleet] Don't ignore "index: false" in integration index template (el…
8f72b39 
…astic#110234)

* fix: don't ignore index prop when falsey

* test: add unit test for index false
@kibanamachine kibanamachine mentioned this pull request Aug 26, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2021
@hop-dev @kibanamachine
[Fleet] Don't ignore "index: false" in integration index template (el…
bb955d8 
…astic#110234)

* fix: don't ignore index prop when falsey

* test: add unit test for index false
@kibanamachine kibanamachine mentioned this pull request Aug 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 26, 2021
@kibanamachine @hop-dev
[Fleet] Don't ignore "index: false" in integration index template (#1…
85893b8 
…10234) (#110273)

* fix: don't ignore index prop when falsey

* test: add unit test for index false

Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
kibanamachine added a commit that referenced this pull request Aug 26, 2021
@kibanamachine @hop-dev
[Fleet] Don't ignore "index: false" in integration index template (#1…
a7eff34 
…10234) (#110274)

* fix: don't ignore index prop when falsey

* test: add unit test for index false

Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@hop-dev hop-dev

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] 'index: false' is ignored in fields when installing templates
4 participants
@hop-dev @elasticmachine @kibanamachine @kpollich