Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix another reference to ALERT_STATUS #110376

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

marshallmain
Copy link
Contributor

Summary

Another reference to ALERT_STATUS slipped in after #109033

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@marshallmain marshallmain requested a review from a team as a code owner August 26, 2021 23:33
@marshallmain
Copy link
Contributor Author

jenkins test this

@jbudz jbudz merged commit 6d7998e into elastic:master Aug 27, 2021
@mgiota
Copy link
Contributor

mgiota commented Aug 27, 2021

@marshallmain This needs to be backported to 7.15. Can you add the labels to your PR?

@marshallmain
Copy link
Contributor Author

@mgiota The backports of the original PR failed due to this missing change. The new backports are building and include this change as well #110383 #110384

@mgiota mgiota mentioned this pull request Aug 30, 2021
52 tasks
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110376 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 31, 2021
@jbudz jbudz added the backport:skip This commit does not require backporting label Aug 31, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants