[Security Solution] Updates loock-back time on Cypress tests #110609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
ecezalp
approved these changes
Aug 31, 2021
xcrzx
approved these changes
Aug 31, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Aug 31, 2021
…#110609) * updates loock-back time * updates loock-back value for 'expectedExportedRule'
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Aug 31, 2021
…#110609) * updates loock-back time * updates loock-back value for 'expectedExportedRule'
This was referenced Aug 31, 2021
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Aug 31, 2021
…#110609) * updates loock-back time * updates loock-back value for 'expectedExportedRule'
MadameSheema
added a commit
that referenced
this pull request
Aug 31, 2021
#110687) * updates loock-back time * updates loock-back value for 'expectedExportedRule'
semd
added a commit
that referenced
this pull request
Sep 1, 2021
* [Security Solution] Updates loock-back time on Cypress tests (#110609) * updates loock-back time * updates loock-back value for 'expectedExportedRule' * skips tests to unblock 7.15 branch * [RAC] Remove rbac on security solution side (#110472) * wip to remove rbac * Revert "[Cases] Include rule registry client for updating alert statuses (#108588)" This reverts commit 1fd7038. This leaves the rule registry mock changes * remove rbac on Trend/Count alert * update detection api for status * remove @kbn-alerts packages * fix leftover * Switching cases to leverage update by query for alert status * Adding missed files * fix bad logic * updating tests for use_alerts_privileges * remove index alias/fields * fix types * fix plugin to get the right index names * left over of alis on template * forget to use current user for create/read route index * updated alerts page to not show table when no privileges and updates to tests * fix bug when switching between o11y and security solution * updates tests and move to use privileges page when user tries to access alerts without proper access * updating jest tests * pairing with yara * bring back kbn-alerts after discussion with the team * fix types * fix index field for o11y * fix bug with updating index priv state * fix i18n issue and update api docs * fix refresh on alerts * fix render view on alerts * updating tests and checking for null in alerts page to not show no privileges page before load * fix details rules Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Yara Tercero <yara.tercero@elastic.co> # Conflicts: # x-pack/plugins/security_solution/cypress/integration/detection_alerts/alerts_details.spec.ts * skip tests Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some tests have started to fail on master because alerts have not been generated.
The only way we have to generate alerts right now on our functional tests, is to load an index with beats data, create a rule using as index the loaded one, and a big loock-back time.
Looks like the current loock-back time is not big enough to generate alerts, this is why in this PR we are updating that value.
In a near future we should investigate different ways to generate alerts as well as updating the current test data.