Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][Security Solution] Make analyzer work with EuiDataGrid full screen #110913

Merged

Conversation

kqualters-elastic
Copy link
Contributor

Summary

This pr makes the analyzer full screen mode compatible with EuiDataGrid full screen. This is done by adding/removing the same class to the body that the data grid does when going full screen, along with some css changes to stretch the graph overlay when in a table.
resolver_full_screen_eui_data_grid

Checklist

@kqualters-elastic kqualters-elastic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete Feature:RAC label obsolete v7.15.0 labels Sep 1, 2021
@kqualters-elastic kqualters-elastic requested review from a team as code owners September 1, 2021 21:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

resetScroll();
} else {
document.body.classList.remove(SCROLLING_DISABLED_CLASS_NAME);
document.body.classList.remove(SCROLLING_DISABLED_CLASS_NAME, 'euiDataGrid__restrictBody');
resetScroll();
}

Copy link
Contributor

@angorayc angorayc Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we able to dispatch setFullScreen for global full screen as well? I could find some style issue due to incorrect global full screen status? Although it seems that the toggle fullscreen button for events table is coming from data grid?
Screenshot 2021-09-02 at 13 58 04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya this is an unrelated z-index issue that was/will be fixed by upgrading eui, #109926 via elastic/eui#5054 I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: turns out it was not fixed, but fixed in this commit 0c1da5a

@kqualters-elastic
Copy link
Contributor Author

Fixed full screen z-index
image

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice fix and it is all legal code in this PR. I appreciate all your effort to get the best way to fix this problem.

Thanks a lot

@kqualters-elastic kqualters-elastic enabled auto-merge (squash) September 2, 2021 17:11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +2.2KB
timelines 421.6KB 422.2KB +641.0B
total +2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit f8e86f5 into elastic:master Sep 2, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v7.16.0

If any of these should not be on your pull request, please manually remove them.

@kqualters-elastic kqualters-elastic deleted the fullscreen-analyzer branch September 2, 2021 17:23
@kqualters-elastic kqualters-elastic restored the fullscreen-analyzer branch September 2, 2021 17:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
…een (elastic#110913)

* Make analyzer work with EuiDataGrid full screen

* Don't ever restrict the width, remove console.log

* Remove isEventViewer prop no longer used

* Make global filters appear below data grid
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
…een (elastic#110913)

* Make analyzer work with EuiDataGrid full screen

* Don't ever restrict the width, remove console.log

* Remove isEventViewer prop no longer used

* Make global filters appear below data grid
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 3, 2021
…een (#110913) (#111017)

* Make analyzer work with EuiDataGrid full screen

* Don't ever restrict the width, remove console.log

* Remove isEventViewer prop no longer used

* Make global filters appear below data grid

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Sep 3, 2021
…een (#110913) (#111018)

* Make analyzer work with EuiDataGrid full screen

* Don't ever restrict the width, remove console.log

* Remove isEventViewer prop no longer used

* Make global filters appear below data grid

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2021
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (65 commits)
  Move to vis_types folder part 2 (elastic#110574)
  [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023)
  [Discover] Remove export* syntax (elastic#110934)
  [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365)
  [Security Solution][Detection Rules] Changes 'activated' text on rule details page  (elastic#111044)
  [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300)
  [package testing] Update logging and pid configuration (elastic#111059)
  [Dashboard] Read App State from URL on Soft Refresh (elastic#109354)
  Add correct roles to test user for functional tests in dashboard (elastic#110880)
  [DOCS] Adds Lens Inspector and minor edits (elastic#109736)
  [DOCS] Updates Spaces page (elastic#111005)
  normalize initialNamespaces (elastic#110936)
  [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740)
  [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253)
  skip flaky suites: elastic#111001, elastic#111022
  [Security Solution][RAC] - Update reason field text (elastic#110308)
  [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913)
  [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971)
  [DOCS] Updates Discover docs (elastic#110346)
  [RAC] Persistent timeline fields fix (elastic#110685)
  ...
@kqualters-elastic kqualters-elastic deleted the fullscreen-analyzer branch June 2, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants