[Security Solution][RAC] Fixes updatedAt loading bug #111010

dplumlee · 2021-09-02T16:20:58Z

Summary

Fixes the "Updated at" field on the Alerts and Rule details page to sync with the timeline data. Also makes the fallback value to no longer be UTC 0, instead defaulting to Date.now()

Videos

Coming soon

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-09-02T16:21:00Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

dplumlee · 2021-09-02T21:08:12Z

@elasticmachine merge upstream

michaelolo24 · 2021-09-03T16:42:36Z

x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.tsx

@@ -331,8 +336,8 @@ const DetectionEnginePageComponent: React.FC<DetectionEngineComponentProps> = ({
                </EuiFlexItem>
                <EuiFlexItem grow={false}>
                  {timelinesUi.getLastUpdated({
-                    updatedAt: updatedAt || 0,
-                    showUpdating: loading,
+                    updatedAt: updatedAt || Date.now(),


Tested, and looks good. I wonder if we should do something here like this so it doesn't even show till we have the updatedAt?

{updatedAt && timelinesUi.getLastUpdated({ updatedAt, showUpdating, })}

It ends up looking like:

withChanges2.mp4

yeah we could go with that instead, cover that little gap in the little

michaelolo24

Thanks for making the changes, looks good, just a suggestion about hiding/showing things, but that may be better left to design to make a decision about what they prefer?

FrankHassanabad

LGTM,

Checked out the branch
Ran the branch and compared against a system without the changes to validate the bug and the fix.
Looked over the code and searched to see if we had any other strings of the form updatedAt || 0 but did not see it so I think all instances were fixed.
Turned on rectangle painting within Chrome and validated that only the label is changed when the timer updates.
Checked the network panel to see if additional network calls were being made or something else (for fun). Did not see anything.
👍

dplumlee · 2021-09-03T20:15:13Z

@elasticmachine merge upstream

peluja1012 · 2021-09-04T01:44:22Z

@elasticmachine merge upstream

michaelolo24 · 2021-09-07T10:53:02Z

@elasticmachine merge upstream

dplumlee · 2021-09-07T15:36:40Z

@elasticmachine merge upstream

kibanamachine · 2021-09-07T17:59:30Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.5MB	6.5MB	+714.0B

History

💔 Build #151435 failed 140a9c4
💔 Build #151109 failed 36ce9ee
💔 Build #151081 failed 9dcfa9c
💔 Build #151049 failed 9dfe5fa
💚 Build #150748 succeeded 0b1a4b1b98e010be24efee66275f1754f7663f2e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

kibanamachine · 2021-09-07T18:02:52Z

💚 Backport successful

Status	Branch	Result
✅	7.15
✅	7.x

The backport PRs will be merged automatically after passing CI.

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (61 commits) [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150) [Archive Migration][Partial] discover apps-discover (elastic#110437) [APM] Set start date of APM ML job to -4 weeks (elastic#111375) [ML] APM Latency Correlations: Code consolidation. (elastic#110790) [Discover] Fix indices permission for multiline test (elastic#111284) [Detection Rules] Add 7.15 rules (elastic#111464) [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064) React version of angular license view (elastic#111317) [APM] Fix link in readme (elastic#111362) [Security Solution] add agent field to generator (elastic#111428) [Dashboard] Retain Tags on Quicksave (elastic#111015) Reorder App Search ingestion methods (elastic#111361) Port performance docs to new docs system. (elastic#111063) [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010) [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885) [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294) Fix copy typo. (elastic#111203) [build] Remove empty optimize directory (elastic#111393) [Maps] fix term join not updating when editing right field (elastic#111030) [Fleet] Set default settings in component template instead of the index template (elastic#111197) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/management/report_listing.test.tsx

dplumlee added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Theme: rac label obsolete v7.15.0 v7.16.0 labels Sep 2, 2021

dplumlee self-assigned this Sep 2, 2021

dplumlee requested a review from a team as a code owner September 2, 2021 16:20

dplumlee requested review from michaelolo24 and a team September 2, 2021 16:21

dplumlee added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 2, 2021

michaelolo24 reviewed Sep 3, 2021

View reviewed changes

michaelolo24 approved these changes Sep 3, 2021

View reviewed changes

FrankHassanabad approved these changes Sep 3, 2021

View reviewed changes

dplumlee added 2 commits September 3, 2021 14:23

adds logic to fix loading state

902bcc6

addresses comments

9dfe5fa

dplumlee force-pushed the updated-at-load-bug branch from 0b1a4b1 to 9dfe5fa Compare September 3, 2021 18:23

dplumlee enabled auto-merge (squash) September 3, 2021 18:52

Merge branch 'master' into updated-at-load-bug

9dcfa9c

Merge branch 'master' into updated-at-load-bug

36ce9ee

Merge branch 'master' into updated-at-load-bug

140a9c4

Merge branch 'master' into updated-at-load-bug

d47af00

dplumlee merged commit 733b17f into elastic:master Sep 7, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2021

[Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)

710db16

kibanamachine mentioned this pull request Sep 7, 2021

[7.15] [Security Solution][RAC] Fixes updatedAt loading bug (#111010) #111440

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2021

[Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)

17804a2

kibanamachine mentioned this pull request Sep 7, 2021

[7.x] [Security Solution][RAC] Fixes updatedAt loading bug (#111010) #111441

Merged

dplumlee deleted the updated-at-load-bug branch September 7, 2021 19:23

kibanamachine added a commit that referenced this pull request Sep 7, 2021

[Security Solution][RAC] Fixes updatedAt loading bug (#111010) (#111440)

673bcfd

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>

kibanamachine added a commit that referenced this pull request Sep 7, 2021

[Security Solution][RAC] Fixes updatedAt loading bug (#111010) (#111441)

0174d72

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>

peluja1012 mentioned this pull request Sep 8, 2021

[Security Solution] Updated at field is broken onLoading #110337

Closed

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021

[Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)

726e760

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][RAC] Fixes updatedAt loading bug #111010

[Security Solution][RAC] Fixes updatedAt loading bug #111010

dplumlee commented Sep 2, 2021 •

edited

Loading

elasticmachine commented Sep 2, 2021

dplumlee commented Sep 2, 2021

michaelolo24 Sep 3, 2021 •

edited

Loading

dplumlee Sep 3, 2021

michaelolo24 left a comment

FrankHassanabad left a comment •

edited

Loading

dplumlee commented Sep 3, 2021

peluja1012 commented Sep 4, 2021

michaelolo24 commented Sep 7, 2021

dplumlee commented Sep 7, 2021

kibanamachine commented Sep 7, 2021

kibanamachine commented Sep 7, 2021

[Security Solution][RAC] Fixes updatedAt loading bug #111010

[Security Solution][RAC] Fixes updatedAt loading bug #111010

Conversation

dplumlee commented Sep 2, 2021 • edited Loading

Summary

Videos

Checklist

For maintainers

elasticmachine commented Sep 2, 2021

dplumlee commented Sep 2, 2021

michaelolo24 Sep 3, 2021 • edited Loading

Choose a reason for hiding this comment

dplumlee Sep 3, 2021

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

FrankHassanabad left a comment • edited Loading

Choose a reason for hiding this comment

dplumlee commented Sep 3, 2021

peluja1012 commented Sep 4, 2021

michaelolo24 commented Sep 7, 2021

dplumlee commented Sep 7, 2021

kibanamachine commented Sep 7, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Sep 7, 2021

💚 Backport successful

dplumlee commented Sep 2, 2021 •

edited

Loading

michaelolo24 Sep 3, 2021 •

edited

Loading

FrankHassanabad left a comment •

edited

Loading