[Fleet] Add icons to Integrations global search results #111131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:enhancement
v8.0.0
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
joshdover
commented
Sep 3, 2021
afharo
approved these changes
Sep 3, 2021
kpollich
approved these changes
Sep 3, 2021
|
Found an opportunity to reduce the bundle size in #111169 |
pgayvallet
approved these changes
Sep 6, 2021
joshdover
added
the
auto-backport
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @joshdover |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
It's the small things :) Nice addition @joshdover ! |
kibanamachine
added a commit
that referenced
this pull request
Sep 7, 2021
|
Hi @EricDavisX We have created below test case for above PR. Link: C150140 Thanks |
|
Hi @EricDavisX We have validated above feature testcases and executed them under following feature test run. Link: 7.16 Ingest feature test plan Please let us know if anything else is required. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #110978
This was easy enough to fix while I was digging around in this code earlier today. Adds the appropriate URL for an integration's SVG icon if available, falling back to an EUI icon if that's available (this is actually currently broken due to elastic/eui#5138).
Checklist
Delete any items that are not applicable to this PR.