[data views] allow fields that start with an underscore in the field list #111238

mattkime · 2021-09-05T05:44:28Z

Summary

Allow fields starting with underscores in data view field lists.

mattkime · 2021-09-06T03:48:31Z

src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_capabilities.ts

    .concat(metaFields)
-    .reduce<{ names: string[]; hash: Record<string, string> }>(
+    .reduce<{ names: string[]; map: Map<string, string> }>(


change to map since this is user provided data, avoiding prototype pollution

elasticmachine · 2021-09-06T05:07:29Z

Pinging @elastic/kibana-app-services (Team:AppServices)

mattkime · 2021-09-06T05:29:56Z

src/plugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.ts

@@ -116,6 +116,8 @@ export function readFieldCapsResponse(
            }),
            {}
          ),
+          // @ts-expect-error


I created a PR to address this - elastic/elasticsearch-js#1547

…ld_names

tsullivan

Code changes LGTM

mattkime · 2021-09-10T12:43:54Z

I need to hold off on this because discover has its own method of creating the field list and it needs to be in agreement with the data view field list

mattkime · 2021-09-13T03:01:01Z

@elasticmachine merge upstream

…ld_names

kibanamachine · 2021-09-13T15:44:44Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 8b3c13f
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup12

Test Failures

Kibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue·ts.alerting api integration spaces only Actions enqueue should never leaved a failed task, even if max attempts is reached

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/111812

[00:00:00]       │
[00:00:00]         └-: alerting api integration spaces only
[00:00:00]           └-> "before all" hook in "alerting api integration spaces only"
[00:00:00]           └-: Actions
[00:00:00]             └-> "before all" hook in "Actions"
[00:00:00]             └-> "before all" hook in "Actions"
[00:00:00]               │ debg creating space
[00:00:01]               │ debg created space
[00:00:01]               │ debg creating space
[00:00:02]               │ debg created space
[00:00:53]             └-: enqueue
[00:00:53]               └-> "before all" hook for "should handle enqueue request appropriately"
[00:00:53]               └-> "before all" hook for "should handle enqueue request appropriately"
[00:00:53]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana-alerting-test-data] creating index, cause [api], templates [], shards [1]/[1]
[00:00:53]               └-> should handle enqueue request appropriately
[00:00:53]                 └-> "before each" hook: global before each for "should handle enqueue request appropriately"
[00:00:54]                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/DJDiNAnPRGSvVVXifXDBaA] update_mapping [_doc]
[00:00:55]                 │ debg --- retry.try error: Expected 1 but received 0.
[00:00:56]                 │ debg --- retry.try failed again with the same message...
[00:00:56]                 │ proc [kibana]   log   [14:14:11.067] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:11.067Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-13T14:14:11.066Z"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:10.472Z","schedule_delay":594000000},"saved_objects":[{"rel":"primary","type":"action","id":"dc4f7010-149c-11ec-8986-35228d326a39","type_id":"test.index-record","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action started: test.index-record:dc4f7010-149c-11ec-8986-35228d326a39: My action","ecs":{"version":"1.8.0"}}
[00:00:56]                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana-alerting-test-data/v6lW9jFdRJqm3kRIgKslBA] update_mapping [_doc]
[00:00:56]                 │ proc [kibana]   log   [14:14:11.494] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:11.493Z","event":{"provider":"actions","action":"execute","start":"2021-09-13T14:14:11.066Z","end":"2021-09-13T14:14:11.493Z","duration":427000000,"outcome":"success"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:10.472Z","schedule_delay":594000000},"saved_objects":[{"rel":"primary","type":"action","id":"dc4f7010-149c-11ec-8986-35228d326a39","type_id":"test.index-record","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action executed: test.index-record:dc4f7010-149c-11ec-8986-35228d326a39: My action","ecs":{"version":"1.8.0"}}
[00:00:56]                 └- ✓ pass  (3.0s) "alerting api integration spaces only Actions enqueue should handle enqueue request appropriately"
[00:00:56]               └-> should cleanup task after a failure
[00:00:56]                 └-> "before each" hook: global before each for "should cleanup task after a failure"
[00:00:58]                 │ debg --- retry.try error: Expected 1 but received 0.
[00:00:59]                 │ debg --- retry.try failed again with the same message...
[00:00:59]                 │ proc [kibana]   log   [14:14:14.074] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:14.073Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-13T14:14:14.073Z"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:13.497Z","schedule_delay":576000000},"saved_objects":[{"rel":"primary","type":"action","id":"de16c290-149c-11ec-8986-35228d326a39","type_id":"test.failing","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action started: test.failing:de16c290-149c-11ec-8986-35228d326a39: My action","ecs":{"version":"1.8.0"}}
[00:00:59]                 │ proc [kibana]   log   [14:14:14.501] [warning][actions][plugins] action execution failure: test.failing:de16c290-149c-11ec-8986-35228d326a39: My action: an error occurred while running the action executor: expected failure for .kibana-alerting-test-data actions-enqueue-2:space1:de16c290-149c-11ec-8986-35228d326a39
[00:00:59]                 │ proc [kibana]   log   [14:14:14.503] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:14.502Z","event":{"provider":"actions","action":"execute","start":"2021-09-13T14:14:14.073Z","end":"2021-09-13T14:14:14.501Z","duration":428000000,"outcome":"failure"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:13.497Z","schedule_delay":576000000},"saved_objects":[{"rel":"primary","type":"action","id":"de16c290-149c-11ec-8986-35228d326a39","type_id":"test.failing","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action execution failure: test.failing:de16c290-149c-11ec-8986-35228d326a39: My action","error":{"message":"an error occurred while running the action executor: expected failure for .kibana-alerting-test-data actions-enqueue-2:space1:de16c290-149c-11ec-8986-35228d326a39"},"ecs":{"version":"1.8.0"}}
[00:00:59]                 │ proc [kibana]   log   [14:14:14.504] [error][actions][plugins] Action 'de16c290-149c-11ec-8986-35228d326a39' failed and will not retry: an error occurred while running the action executor
[00:00:59]                 │ debg --- retry.try error: expected 1 to sort of equal 0
[00:01:00]                 │ debg --- retry.try failed again with the same message...
[00:01:00]                 │ debg --- retry.try failed again with the same message...
[00:01:01]                 └- ✓ pass  (4.6s) "alerting api integration spaces only Actions enqueue should cleanup task after a failure"
[00:01:01]               └-> should never leaved a failed task, even if max attempts is reached
[00:01:01]                 └-> "before each" hook: global before each for "should never leaved a failed task, even if max attempts is reached"
[00:01:02]                 │ debg --- retry.try error: expected 0 to sort of equal 1
[00:01:03]                 │ debg --- retry.try failed again with the same message...
[00:01:03]                 │ debg --- retry.try failed again with the same message...
[00:01:04]                 │ debg --- retry.try failed again with the same message...
[00:01:04]                 │ debg --- retry.try failed again with the same message...
[00:01:05]                 │ proc [kibana]   log   [14:14:20.046] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:20.045Z","event":{"provider":"actions","action":"execute-start","start":"2021-09-13T14:14:20.045Z"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:17.524Z","schedule_delay":2521000000},"saved_objects":[{"rel":"primary","type":"action","id":"e0d03d40-149c-11ec-8986-35228d326a39","type_id":"test.no-attempts-rate-limit","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action started: test.no-attempts-rate-limit:e0d03d40-149c-11ec-8986-35228d326a39: My action","ecs":{"version":"1.8.0"}}
[00:01:05]                 │ debg --- retry.try failed again with the same message...
[00:01:05]                 │ proc [kibana]   log   [14:14:20.508] [warning][actions][plugins] action execution failure: test.no-attempts-rate-limit:e0d03d40-149c-11ec-8986-35228d326a39: My action: unknown error running action; retry at 2021-09-13T14:14:16.080Z
[00:01:05]                 │ proc [kibana]   log   [14:14:20.509] [info][eventLog][plugins] event logged: {"@timestamp":"2021-09-13T14:14:20.508Z","event":{"provider":"actions","action":"execute","start":"2021-09-13T14:14:20.045Z","end":"2021-09-13T14:14:20.508Z","duration":463000000,"outcome":"failure"},"kibana":{"task":{"scheduled":"2021-09-13T14:14:17.524Z","schedule_delay":2521000000},"saved_objects":[{"rel":"primary","type":"action","id":"e0d03d40-149c-11ec-8986-35228d326a39","type_id":"test.no-attempts-rate-limit","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d","version":"8.0.0"},"message":"action execution failure: test.no-attempts-rate-limit:e0d03d40-149c-11ec-8986-35228d326a39: My action","error":{"message":"unknown error running action; retry at 2021-09-13T14:14:16.080Z"},"ecs":{"version":"1.8.0"}}
[00:01:05]                 │ proc [kibana]   log   [14:14:20.510] [error][actions][plugins] Action 'e0d03d40-149c-11ec-8986-35228d326a39' failed and will not retry: undefined
[00:01:05]                 │ debg --- retry.try failed again with the same message...
[00:01:06]                 │ debg --- retry.try failed again with the same message...
[00:01:06]                 │ debg --- retry.try failed again with the same message...
[00:01:07]                 │ debg --- retry.try failed again with the same message...
[00:01:07]                 │ debg --- retry.try failed again with the same message...
[00:01:08]                 │ debg --- retry.try failed again with the same message...
[00:01:08]                 │ debg --- retry.try failed again with the same message...
[00:01:09]                 │ debg --- retry.try failed again with the same message...
[00:01:09]                 │ debg --- retry.try failed again with the same message...
[00:01:10]                 │ debg --- retry.try failed again with the same message...
[00:01:10]                 │ debg --- retry.try failed again with the same message...
[00:01:11]                 │ debg --- retry.try failed again with the same message...
[00:01:11]                 │ debg --- retry.try failed again with the same message...
[00:01:12]                 │ debg --- retry.try failed again with the same message...
[00:01:12]                 │ debg --- retry.try failed again with the same message...
[00:01:13]                 │ debg --- retry.try failed again with the same message...
[00:01:13]                 │ debg --- retry.try failed again with the same message...
[00:01:14]                 │ debg --- retry.try failed again with the same message...
[00:01:14]                 │ debg --- retry.try failed again with the same message...
[00:01:15]                 │ debg --- retry.try failed again with the same message...
[00:01:15]                 │ debg --- retry.try failed again with the same message...
[00:01:16]                 │ debg --- retry.try failed again with the same message...
[00:01:16]                 │ debg --- retry.try failed again with the same message...
[00:01:17]                 │ debg --- retry.try failed again with the same message...
[00:01:17]                 │ debg --- retry.try failed again with the same message...
[00:01:18]                 │ debg --- retry.try failed again with the same message...
[00:01:18]                 │ debg --- retry.try failed again with the same message...
[00:01:19]                 │ debg --- retry.try failed again with the same message...
[00:01:19]                 │ debg --- retry.try failed again with the same message...
[00:01:20]                 │ debg --- retry.try failed again with the same message...
[00:01:20]                 │ debg --- retry.try failed again with the same message...
[00:01:21]                 │ debg --- retry.try failed again with the same message...
[00:01:21]                 │ debg --- retry.try failed again with the same message...
[00:01:22]                 │ debg --- retry.try failed again with the same message...
[00:01:22]                 │ debg --- retry.try failed again with the same message...
[00:01:23]                 │ debg --- retry.try failed again with the same message...
[00:01:23]                 │ debg --- retry.try failed again with the same message...
[00:01:24]                 │ debg --- retry.try failed again with the same message...
[00:01:25]                 │ debg --- retry.try failed again with the same message...
[00:01:25]                 │ debg --- retry.try failed again with the same message...
[00:01:26]                 │ debg --- retry.try failed again with the same message...
[00:01:26]                 │ debg --- retry.try failed again with the same message...
[00:01:27]                 │ debg --- retry.try failed again with the same message...
[00:01:27]                 │ debg --- retry.try failed again with the same message...
[00:01:28]                 │ debg --- retry.try failed again with the same message...
[00:01:28]                 │ debg --- retry.try failed again with the same message...
[00:01:29]                 │ debg --- retry.try failed again with the same message...
[00:01:29]                 │ debg --- retry.try failed again with the same message...
[00:01:30]                 │ debg --- retry.try failed again with the same message...
[00:01:30]                 │ debg --- retry.try failed again with the same message...
[00:01:31]                 │ debg --- retry.try failed again with the same message...
[00:01:31]                 │ debg --- retry.try failed again with the same message...
[00:01:32]                 │ debg --- retry.try failed again with the same message...
[00:01:32]                 │ debg --- retry.try failed again with the same message...
[00:01:33]                 │ debg --- retry.try failed again with the same message...
[00:01:33]                 │ debg --- retry.try failed again with the same message...
[00:01:34]                 │ debg --- retry.try failed again with the same message...
[00:01:34]                 │ debg --- retry.try failed again with the same message...
[00:01:35]                 │ debg --- retry.try failed again with the same message...
[00:01:35]                 │ debg --- retry.try failed again with the same message...
[00:01:36]                 │ debg --- retry.try failed again with the same message...
[00:01:36]                 │ debg --- retry.try failed again with the same message...
[00:01:37]                 │ debg --- retry.try failed again with the same message...
[00:01:37]                 │ debg --- retry.try failed again with the same message...
[00:01:38]                 │ debg --- retry.try failed again with the same message...
[00:01:38]                 │ debg --- retry.try failed again with the same message...
[00:01:39]                 │ debg --- retry.try failed again with the same message...
[00:01:39]                 │ debg --- retry.try failed again with the same message...
[00:01:40]                 │ debg --- retry.try failed again with the same message...
[00:01:40]                 │ debg --- retry.try failed again with the same message...
[00:01:41]                 │ debg --- retry.try failed again with the same message...
[00:01:41]                 │ debg --- retry.try failed again with the same message...
[00:01:42]                 │ debg --- retry.try failed again with the same message...
[00:01:42]                 │ debg --- retry.try failed again with the same message...
[00:01:43]                 │ debg --- retry.try failed again with the same message...
[00:01:43]                 │ debg --- retry.try failed again with the same message...
[00:01:44]                 │ debg --- retry.try failed again with the same message...
[00:01:44]                 │ debg --- retry.try failed again with the same message...
[00:01:45]                 │ debg --- retry.try failed again with the same message...
[00:01:45]                 │ debg --- retry.try failed again with the same message...
[00:01:46]                 │ debg --- retry.try failed again with the same message...
[00:01:46]                 │ debg --- retry.try failed again with the same message...
[00:01:47]                 │ debg --- retry.try failed again with the same message...
[00:01:47]                 │ debg --- retry.try failed again with the same message...
[00:01:48]                 │ debg --- retry.try failed again with the same message...
[00:01:48]                 │ debg --- retry.try failed again with the same message...
[00:01:49]                 │ debg --- retry.try failed again with the same message...
[00:01:49]                 │ debg --- retry.try failed again with the same message...
[00:01:50]                 │ debg --- retry.try failed again with the same message...
[00:01:50]                 │ debg --- retry.try failed again with the same message...
[00:01:51]                 │ debg --- retry.try failed again with the same message...
[00:01:51]                 │ debg --- retry.try failed again with the same message...
[00:01:52]                 │ debg --- retry.try failed again with the same message...
[00:01:52]                 │ debg --- retry.try failed again with the same message...
[00:01:53]                 │ debg --- retry.try failed again with the same message...
[00:01:53]                 │ debg --- retry.try failed again with the same message...
[00:01:54]                 │ debg --- retry.try failed again with the same message...
[00:01:54]                 │ debg --- retry.try failed again with the same message...
[00:01:55]                 │ debg --- retry.try failed again with the same message...
[00:01:56]                 │ debg --- retry.try failed again with the same message...
[00:01:56]                 │ debg --- retry.try failed again with the same message...
[00:01:57]                 │ debg --- retry.try failed again with the same message...
[00:01:57]                 │ debg --- retry.try failed again with the same message...
[00:01:58]                 │ debg --- retry.try failed again with the same message...
[00:01:58]                 │ debg --- retry.try failed again with the same message...
[00:01:59]                 │ debg --- retry.try failed again with the same message...
[00:01:59]                 │ debg --- retry.try failed again with the same message...
[00:02:00]                 │ debg --- retry.try failed again with the same message...
[00:02:00]                 │ debg --- retry.try failed again with the same message...
[00:02:01]                 │ debg --- retry.try failed again with the same message...
[00:02:01]                 │ debg --- retry.try failed again with the same message...
[00:02:02]                 │ debg --- retry.try failed again with the same message...
[00:02:02]                 │ debg --- retry.try failed again with the same message...
[00:02:03]                 │ debg --- retry.try failed again with the same message...
[00:02:03]                 │ debg --- retry.try failed again with the same message...
[00:02:04]                 │ debg --- retry.try failed again with the same message...
[00:02:04]                 │ debg --- retry.try failed again with the same message...
[00:02:05]                 │ debg --- retry.try failed again with the same message...
[00:02:05]                 │ debg --- retry.try failed again with the same message...
[00:02:06]                 │ debg --- retry.try failed again with the same message...
[00:02:06]                 │ debg --- retry.try failed again with the same message...
[00:02:07]                 │ debg --- retry.try failed again with the same message...
[00:02:07]                 │ debg --- retry.try failed again with the same message...
[00:02:08]                 │ debg --- retry.try failed again with the same message...
[00:02:08]                 │ debg --- retry.try failed again with the same message...
[00:02:09]                 │ debg --- retry.try failed again with the same message...
[00:02:09]                 │ debg --- retry.try failed again with the same message...
[00:02:10]                 │ debg --- retry.try failed again with the same message...
[00:02:10]                 │ debg --- retry.try failed again with the same message...
[00:02:11]                 │ debg --- retry.try failed again with the same message...
[00:02:11]                 │ debg --- retry.try failed again with the same message...
[00:02:12]                 │ debg --- retry.try failed again with the same message...
[00:02:12]                 │ debg --- retry.try failed again with the same message...
[00:02:13]                 │ debg --- retry.try failed again with the same message...
[00:02:13]                 │ debg --- retry.try failed again with the same message...
[00:02:14]                 │ debg --- retry.try failed again with the same message...
[00:02:14]                 │ debg --- retry.try failed again with the same message...
[00:02:15]                 │ debg --- retry.try failed again with the same message...
[00:02:15]                 │ debg --- retry.try failed again with the same message...
[00:02:16]                 │ debg --- retry.try failed again with the same message...
[00:02:16]                 │ debg --- retry.try failed again with the same message...
[00:02:17]                 │ debg --- retry.try failed again with the same message...
[00:02:17]                 │ debg --- retry.try failed again with the same message...
[00:02:18]                 │ debg --- retry.try failed again with the same message...
[00:02:18]                 │ debg --- retry.try failed again with the same message...
[00:02:19]                 │ debg --- retry.try failed again with the same message...
[00:02:19]                 │ debg --- retry.try failed again with the same message...
[00:02:20]                 │ debg --- retry.try failed again with the same message...
[00:02:20]                 │ debg --- retry.try failed again with the same message...
[00:02:21]                 │ debg --- retry.try failed again with the same message...
[00:02:21]                 │ debg --- retry.try failed again with the same message...
[00:02:22]                 │ debg --- retry.try failed again with the same message...
[00:02:22]                 │ debg --- retry.try failed again with the same message...
[00:02:23]                 │ debg --- retry.try failed again with the same message...
[00:02:23]                 │ debg --- retry.try failed again with the same message...
[00:02:24]                 │ debg --- retry.try failed again with the same message...
[00:02:24]                 │ debg --- retry.try failed again with the same message...
[00:02:25]                 │ debg --- retry.try failed again with the same message...
[00:02:25]                 │ debg --- retry.try failed again with the same message...
[00:02:26]                 │ debg --- retry.try failed again with the same message...
[00:02:26]                 │ debg --- retry.try failed again with the same message...
[00:02:27]                 │ debg --- retry.try failed again with the same message...
[00:02:28]                 │ debg --- retry.try failed again with the same message...
[00:02:28]                 │ debg --- retry.try failed again with the same message...
[00:02:29]                 │ debg --- retry.try failed again with the same message...
[00:02:29]                 │ debg --- retry.try failed again with the same message...
[00:02:30]                 │ debg --- retry.try failed again with the same message...
[00:02:30]                 │ debg --- retry.try failed again with the same message...
[00:02:31]                 │ debg --- retry.try failed again with the same message...
[00:02:31]                 │ debg --- retry.try failed again with the same message...
[00:02:32]                 │ debg --- retry.try failed again with the same message...
[00:02:32]                 │ debg --- retry.try failed again with the same message...
[00:02:33]                 │ debg --- retry.try failed again with the same message...
[00:02:33]                 │ debg --- retry.try failed again with the same message...
[00:02:34]                 │ debg --- retry.try failed again with the same message...
[00:02:34]                 │ debg --- retry.try failed again with the same message...
[00:02:35]                 │ debg --- retry.try failed again with the same message...
[00:02:35]                 │ debg --- retry.try failed again with the same message...
[00:02:36]                 │ debg --- retry.try failed again with the same message...
[00:02:36]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:37]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try failed again with the same message...
[00:02:38]                 │ debg --- retry.try failed again with the same message...
[00:02:39]                 │ debg --- retry.try failed again with the same message...
[00:02:39]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:40]                 │ debg --- retry.try failed again with the same message...
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:41]                 │ debg --- retry.try failed again with the same message...
[00:02:42]                 │ debg --- retry.try failed again with the same message...
[00:02:42]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:43]                 │ debg --- retry.try failed again with the same message...
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:44]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:45]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ debg --- retry.try failed again with the same message...
[00:02:46]                 │ debg --- retry.try failed again with the same message...
[00:02:47]                 │ debg --- retry.try failed again with the same message...
[00:02:47]                 │ debg --- retry.try failed again with the same message...
[00:02:48]                 │ debg --- retry.try failed again with the same message...
[00:02:48]                 │ debg --- retry.try failed again with the same message...
[00:02:49]                 │ debg --- retry.try failed again with the same message...
[00:02:49]                 │ debg --- retry.try failed again with the same message...
[00:02:50]                 │ debg --- retry.try failed again with the same message...
[00:02:50]                 │ debg --- retry.try failed again with the same message...
[00:02:51]                 │ debg --- retry.try failed again with the same message...
[00:02:51]                 │ debg --- retry.try failed again with the same message...
[00:02:52]                 │ debg --- retry.try failed again with the same message...
[00:02:52]                 │ debg --- retry.try failed again with the same message...
[00:02:53]                 │ debg --- retry.try failed again with the same message...
[00:02:53]                 │ debg --- retry.try failed again with the same message...
[00:02:54]                 │ debg --- retry.try failed again with the same message...
[00:02:54]                 │ debg --- retry.try failed again with the same message...
[00:02:55]                 │ debg --- retry.try failed again with the same message...
[00:02:55]                 │ debg --- retry.try failed again with the same message...
[00:02:56]                 │ debg --- retry.try failed again with the same message...
[00:02:56]                 │ debg --- retry.try failed again with the same message...
[00:02:57]                 │ debg --- retry.try failed again with the same message...
[00:02:57]                 │ debg --- retry.try failed again with the same message...
[00:02:58]                 │ debg --- retry.try failed again with the same message...
[00:02:58]                 │ debg --- retry.try failed again with the same message...
[00:02:59]                 │ debg --- retry.try failed again with the same message...
[00:03:00]                 │ debg --- retry.try failed again with the same message...
[00:03:00]                 │ debg --- retry.try failed again with the same message...
[00:03:01]                 │ debg --- retry.try failed again with the same message...
[00:03:01]                 │ debg --- retry.try failed again with the same message...
[00:03:02]                 │ debg --- retry.try failed again with the same message...
[00:03:02]                 │ debg --- retry.try failed again with the same message...
[00:03:03]                 └- ✖ fail: alerting api integration spaces only Actions enqueue should never leaved a failed task, even if max attempts is reached
[00:03:03]                 │      retry.try timeout: Error: expected 0 to sort of equal 1
[00:03:03]                 │     at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:03:03]                 │     at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:03:03]                 │     at /dev/shm/workspace/parallel/18/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
[00:03:03]                 │     at runMicrotasks (<anonymous>)
[00:03:03]                 │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:03:03]                 │     at runAttempt (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:03:03]                 │     at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:03:03]                 │     at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:03]                 │     at Context.<anonymous> (/dev/shm/workspace/parallel/18/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:03]                 │     at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:03]                 │   Error: retry.try timeout: Error: expected 0 to sort of equal 1
[00:03:03]                 │       at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:03:03]                 │       at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:03:03]                 │       at /dev/shm/workspace/parallel/18/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
[00:03:03]                 │       at runMicrotasks (<anonymous>)
[00:03:03]                 │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:03:03]                 │       at runAttempt (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:03:03]                 │       at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:03:03]                 │       at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:03]                 │       at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:03]                 │       at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:03]                 │       at onFailure (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:03:03]                 │       at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:03:03]                 │       at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
[00:03:03]                 │       at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
[00:03:03]                 │       at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:03:03]                 │ 
[00:03:03]                 │

Stack Trace

Error: retry.try timeout: Error: expected 0 to sort of equal 1
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at /dev/shm/workspace/parallel/18/kibana/x-pack/test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:182:91
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runAttempt (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
    at onFailure (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/spaces_only/tests/actions/enqueue.ts:160:7)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2738	2739	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	777.9KB	777.8KB	-84.0B

Unknown metric groups

API count

id	before	after	diff
`data`	3099	3100	+1

History

💚 Build #152708 succeeded 1f2067a
💛 Build #152442 was flaky 05705bc
💔 Build #152438 failed 44b02b0
💔 Build #152441 failed 87c4c87
💔 Build #152437 failed bcb26e2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…list (elastic#111238) * stop filtering out fields that start with underscore

kibanamachine · 2021-09-13T15:49:28Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…list (#111238) (#111976) * stop filtering out fields that start with underscore Co-authored-by: Matthew Kime <matt@mattki.me>

mattkime added 5 commits September 5, 2021 00:40

stop filtering out fields that start with underscore

67b9650

only include meta fields included in list

646a627

fix metafields

b01605c

typescript fix

25ed172

fix api integration test

2a315fb

mattkime changed the title ~~stop filtering out fields that start with underscore~~ [data views] allow fields that start with an underscore in the field list Sep 5, 2021

mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServices v7.16.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:feature Makes this part of the condensed release notes labels Sep 5, 2021

mattkime added 2 commits September 5, 2021 11:24

api integration test fix

cf59f53

fix api integration tests

c87f004

mattkime commented Sep 6, 2021

View reviewed changes

mattkime marked this pull request as ready for review September 6, 2021 05:07

mattkime requested a review from a team as a code owner September 6, 2021 05:07

mattkime commented Sep 6, 2021

View reviewed changes

mattkime added 5 commits September 9, 2021 21:39

Merge branch 'master' into allow_leading_underscores_in_data_view_fie…

9ef0494

…ld_names

add test

bcb26e2

fix integration test

44b02b0

remove only

87c4c87

fix integration test

05705bc

tsullivan approved these changes Sep 10, 2021

View reviewed changes

kibanamachine and others added 2 commits September 12, 2021 23:01

Merge branch 'master' into allow_leading_underscores_in_data_view_fie…

1f2067a

…ld_names

fix discover field list to allow underscores

8b3c13f

mattkime merged commit 3fd7dbe into elastic:master Sep 13, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021

[data views] allow fields that start with an underscore in the field …

83ff4b9

…list (elastic#111238) * stop filtering out fields that start with underscore

kibanamachine mentioned this pull request Sep 13, 2021

[7.x] [data views] allow fields that start with an underscore in the field list (#111238) #111976

Merged

kibanamachine added a commit that referenced this pull request Sep 13, 2021

[data views] allow fields that start with an underscore in the field …

f932175

…list (#111238) (#111976) * stop filtering out fields that start with underscore Co-authored-by: Matthew Kime <matt@mattki.me>

mattkime mentioned this pull request Oct 5, 2021

Warn when mapping contains fields starting with _ #2929

Closed

KOTungseth added Feature:Index Management Index and index templates UI Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Nov 19, 2021

mattkime mentioned this pull request Dec 21, 2021

[data views] remove _timestamp field overrides #121772

Merged

jklare mentioned this pull request Aug 29, 2023

[Feature Request] Support fields that start with an underscore ("_") opensearch-project/OpenSearch-Dashboards#3602

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data views] allow fields that start with an underscore in the field list #111238

[data views] allow fields that start with an underscore in the field list #111238

mattkime commented Sep 5, 2021 •

edited

Loading

mattkime Sep 6, 2021

elasticmachine commented Sep 6, 2021

mattkime Sep 6, 2021

tsullivan left a comment

mattkime commented Sep 10, 2021

mattkime commented Sep 13, 2021

kibanamachine commented Sep 13, 2021

Standard Out

Stack Trace

API count

kibanamachine commented Sep 13, 2021

[data views] allow fields that start with an underscore in the field list #111238

[data views] allow fields that start with an underscore in the field list #111238

Conversation

mattkime commented Sep 5, 2021 • edited Loading

Summary

mattkime Sep 6, 2021

Choose a reason for hiding this comment

elasticmachine commented Sep 6, 2021

mattkime Sep 6, 2021

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

mattkime commented Sep 10, 2021

mattkime commented Sep 13, 2021

kibanamachine commented Sep 13, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

History

kibanamachine commented Sep 13, 2021

💚 Backport successful

mattkime commented Sep 5, 2021 •

edited

Loading