Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Platform initial setup #11192

Closed
wants to merge 2 commits into from
Closed

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Apr 12, 2017

Very initial setup stuff for #9675, this is just to demo some ideas. (Still missing tons of tests.)

This contains basic setup for Flow, rxjs, the cli and config files.

Copying what I put in platform/README.md for now:

Flow

First install flow-typed:

npm install -g flow-typed

Then run:

flow-typed install

This pulls (or generates empty) Flow libdefs for dependencies into the ./flow-typed folder.

(If we keep Flow we'll follow the recommended setup and commit flow-typed/ to our repo.)

Types in VSCode

To get Flow running in VSCode:

$ cat .vscode/settings.json
{
  "flow.enabled": true,
  "flow.useNPMPackagedFlow": true,
  "flow.stopFlowOnExit": true,
  "javascript.validate.enable": false
}

For other editors check out https://flow.org/en/docs/editors/

Running code

Just shows the parsed config:

node scripts/platform.js -c ./config/kibana.dev.yml

With failure (for now, as logging is missing in the schema):

node scripts/platform.js -c ./config/kibana.dev.yml -q

@kimjoar kimjoar added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 12, 2017
First install [`flow-typed`](https://github.com/flowtype/flow-typed):

```
npm install -g flow-typed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this with a devDependency instead? People shouldn't need to self-manage npm dependencies or use global installs.

@kimjoar
Copy link
Contributor Author

kimjoar commented Apr 15, 2017

Closing in favour of new upcoming PR.

@kimjoar kimjoar closed this Apr 15, 2017
@kimjoar kimjoar deleted the platform-setup branch April 26, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants