remove last usages of plugin async lifecycles #112111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
commented
Sep 14, 2021
| @@ -78,8 +76,9 @@ export class CorsTestPlugin implements Plugin { | |||
| return h.response(renderBody(kibanaUrl)); | |||
| }, | |||
| }); | |||
| await server.start(); | |||
| server.start(); | |||
There was a problem hiding this comment.
We're no longer waiting for the underlying server to start, but from some local testing, it doesn't seem to introduce flakiness to the associated test suite.
Comment on lines
+16
to
+21
| core.application.applications$ | ||
| .pipe(first()) | ||
| .toPromise() | ||
| .then((applications) => { | ||
| window.__applicationIds__ = [...applications.keys()]; | ||
| }); |
There was a problem hiding this comment.
Same, in practice, this resolves before any test is effectively running
pgayvallet
added
chore
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
approved these changes
Sep 15, 2021
matschaffer
approved these changes
Sep 16, 2021
rudolf
approved these changes
Sep 20, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 21, 2021
* remove last usages of plugin async lifecycles * fix contract type * fix types. again. * remove unused import
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #53268
Remove the last usages of asynchronous lifecycle methods for plugins in the codebase.