Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more doc links for ingest pipelines app #112767

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Update more doc links for ingest pipelines app #112767

merged 5 commits into from
Sep 23, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 22, 2021

Summary

Relates to #88107

Similar to #94742, this PR updates links in the ingest node pipelines app to use the documentation link service.

@lcawl lcawl added enhancement New value added to drive a business result Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Sep 22, 2021
@lcawl lcawl mentioned this pull request Sep 22, 2021
Closed
@lcawl lcawl marked this pull request as ready for review September 22, 2021 14:46
@lcawl lcawl requested review from a team as code owners September 22, 2021 14:46
cjcenizal
cjcenizal suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @lcawl! I tested locally and found one broken link due to a duplicate variable name in documentation.ts. I also had some more nitpicky suggestions.

x-pack/plugins/ingest_pipelines/public/application/services/documentation.ts Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/services/documentation.ts Outdated Show resolved Hide resolved
...ic/application/components/pipeline_editor/components/processor_form/processors/inference.tsx Outdated Show resolved Hide resolved
...ic/application/components/pipeline_editor/components/processor_form/processors/inference.tsx Outdated Show resolved Hide resolved
lukeelmers
lukeelmers approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core changes lgtm

cjcenizal
cjcenizal approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM!

@lcawl
Copy link
Contributor Author

lcawl commented Sep 22, 2021

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 452.8KB 452.5KB -249.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 293.6KB 293.6KB +47.0B
ingestPipelines 11.6KB 12.4KB +775.0B
total +822.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit acf6a02 into elastic:master Sep 23, 2021
@lcawl lcawl deleted the ingest-links2 branch September 23, 2021 16:29
@lcawl lcawl added the v7.15.1 label Sep 23, 2021
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 23, 2021
@lcawl
Update more doc links for ingest pipelines app (elastic#112767)
860c4c2
@lcawl lcawl mentioned this pull request Sep 23, 2021
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 23, 2021
@lcawl
Update more doc links for ingest pipelines app (elastic#112767)
749e518
@lcawl lcawl mentioned this pull request Sep 23, 2021
Merged
lcawl added a commit that referenced this pull request Sep 23, 2021
@lcawl
Update more doc links for ingest pipelines app (#112767) (#113010)
4ed393d
lcawl added a commit that referenced this pull request Sep 23, 2021
@lcawl
Update more doc links for ingest pipelines app (#112767) (#113009)
54d0621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @tylersmalley @kibanamachine @cjcenizal @lukeelmers