Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix possible unhandled promise in preconfiguration service #112827

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[Fleet] Fix possible unhandled promise in preconfiguration service #112827

merged 1 commit into from
Sep 22, 2021

Conversation

nchaulet
Copy link
Member

Description

Add a missing await in the preconfiguration service. The fix was done as part of this PR in master and 7.x #111002

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.1 labels Sep 22, 2021
@nchaulet nchaulet requested a review from joshdover September 22, 2021 13:22
@nchaulet nchaulet self-assigned this Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

criamico
criamico approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 498f232 into elastic:7.15 Sep 22, 2021
@nchaulet nchaulet deleted the fix-possible-unhandled-promise-fleet-preconfiguration branch September 22, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

@criamico criamico criamico approved these changes

Assignees

@nchaulet nchaulet

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibanamachine @joshdover @criamico