fix skipped test test/accessibility/apps/dashboard·ts - Dashboard create dashboard button #111233 #112872
Conversation
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
This should do it - the problem was with CentOS, which is currently not in the pool. |
|
I do want to confirm that we aren't adding sleeps to resolve this, however. |
LeeDr
changed the title
|
Passed 100 iterations on flaky test runner |
LeeDr
added
v7.16.0
v8.0.0
Project:Accessibility
test_ui_functional
auto-backport
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
| @@ -17,15 +17,19 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { | |||
| ...functionalConfig.getAll(), | |||
|
|
|||
| testFiles: [ | |||
| require.resolve('./apps/discover'), | |||
| // these 5 tests all load addSampleDataSet('flights') | |||
| // only the last test does removeSampleDataSet('flights') | |||
There was a problem hiding this comment.
NOTE: I started going down the path to create an index file with a before and after to load/unload the sample data for this group of tests but the last test kibana_overview appears to have tests for both states where there is and isn't data. I need to talk to @bhavyarm about refactoring these. But I'd like to get the test unskipped in any case.
|
@elasticmachine merge upstream |
No sleeps added. That was just to try to tell if it was a timing problem. I didn't really prove it one way or the other but added a retry in adding the sample data. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…ate dashboard button elastic#111233 (elastic#112872) * test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…ate dashboard button #111233 (#112872) (#113317) * test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Summary
Fixes: #111233
Details in the issue ^. Although the before method should have added the sample data, the failure makes it look like it wasn't added. Although I initially tested adding a 2s sleep, I later changed it to a retry.waitFor.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers