Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize custom URLs tests #113096

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Sep 27, 2021

Summary

This PR stabilizes the functional custom URLs tests by adding retries for the dashboard and other type URL save service methods, similar to what we already have in the discover type URL save service method.

Closes #106053

@pheyos pheyos requested a review from a team as a code owner September 27, 2021 09:30
@pheyos pheyos self-assigned this Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Sep 27, 2021

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 27, 2021
@pheyos pheyos merged commit 314227d into elastic:master Sep 27, 2021
@pheyos pheyos deleted the stabilize_custom_urls_tests branch September 27, 2021 13:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2021
This PR stabilizes the functional custom URLs tests by adding retries for the dashboard and other type URL save service methods, similar to what we already have in the discover type URL save service method.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2021
This PR stabilizes the functional custom URLs tests by adding retries for the dashboard and other type URL save service methods, similar to what we already have in the discover type URL save service method.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 27, 2021
This PR stabilizes the functional custom URLs tests by adding retries for the dashboard and other type URL save service methods, similar to what we already have in the discover type URL save service method.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 27, 2021
This PR stabilizes the functional custom URLs tests by adding retries for the dashboard and other type URL save service methods, similar to what we already have in the discover type URL save service method.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.15.1 v7.16.0 v8.0.0
Projects
None yet
5 participants