Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Dashboard] Enabled inspector panel for ux dashboard #113118

Merged
merged 4 commits into from
Sep 29, 2021
Merged

[UX Dashboard] Enabled inspector panel for ux dashboard #113118

merged 4 commits into from
Sep 29, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 27, 2021 •
edited
Loading

Summary

Fix #113120

Enabled inspect panel for UX dashboard, when user enable inspect queries from advacned settings for observability, inspect button will show up in ux dashbaord

image

@shahzad31 shahzad31 self-assigned this Sep 27, 2021
@shahzad31 shahzad31 marked this pull request as ready for review September 27, 2021 13:51
@shahzad31 shahzad31 requested a review from a team as a code owner September 27, 2021 13:51
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

justinkambic
justinkambic approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +204.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 25695b5 into elastic:master Sep 29, 2021
@shahzad31 shahzad31 deleted the ux-app-inspector-panel branch September 29, 2021 09:44
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 29, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@shahzad31 @kibanamachine
[UX Dashboard] Enabled inspector panel for ux dashboard (elastic#113118)
c3a045e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
@kibanamachine @shahzad31
[UX Dashboard] Enabled inspector panel for ux dashboard (#113118) (#1…
91a1679 
…13369)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable inspector panel for UX dashboard
4 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic