-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Use oldest exit span instead of newest #113133
[APM] Use oldest exit span instead of newest #113133
Conversation
For discovering connections, select the oldest span instead of the newest. This increases the possiblity of the relevant transaction being indexed into Elasticsearch at query time.
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix. Do we need to update any tests for this (and if not, is that ok?)
This issue exhibits itself only when there are indexing delays (between the exit span and entry transaction). So it's quite hard to replicate with an Elasticsearch archive, e.g. you can't use a specific time range. My feeling is that it's not worth the overhead of a (very specific) API test, what do you think? |
Makes sense 👍 |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
For discovering connections, select the oldest span instead of the newest. This increases the possiblity of the relevant transaction being indexed into Elasticsearch at query time. If this tranasaction isn't there, exit spans might not be appropriately resolved to the downstream service, as reported by @felixbarny and @LucaWintergerst.