[Security Solution] Fix inspect button bug on the overview page #113161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecezalp
added
release_note:fix
v8.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2021
…tic#113161) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2021
) (#113187) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ece Özalp <ozale272@newschool.edu>
testing instructions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had identified a bug (while working on elastic/security-team#1308) where sometimes the inspect modals on the Overview page did not open when the inspect button was clicked.
This change fixes the bug by disabling the clearAllQuery logic in the useGlobalTime hook used in the alerts histogram panel.
Testing:
Further testing:
inputs.global.queriesarray. When the clearAllQuery is true and you refresh the page, you can see that the array usually has two or three items. When you make clearAllQuery false, you can see that there are consistently 7 items in theinput.global.queriesarray and all of the inspect modals work as expected.