Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Fixed Jest test suites with unhandled promise rejections #113213

Merged
merged 2 commits into from
Sep 28, 2021
Merged

[Alerting] Fixed Jest test suites with unhandled promise rejections #113213

merged 2 commits into from
Sep 28, 2021

Conversation

YulNaumenko
Copy link
Contributor

Summary

Current PR fixed UnhandledPromiseRejectionWarning: ... which caused in the next Alerting jest tests:
x-pack/plugins/stack_alerts/server/feature.test.ts
x-pack/plugins/stack_alerts/server/plugin.test.ts
x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.test.tsx
x-pack/plugins/triggers_actions_ui/server/data/lib/time_series_query.test.ts

To test it just run each suite using command:

node scripts/jest <suite>

Resolves #112703

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Sep 28, 2021
@YulNaumenko YulNaumenko self-assigned this Sep 28, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner September 28, 2021 05:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job :)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

chrisronline
chrisronline approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko merged commit 3dcfd44 into elastic:master Sep 28, 2021
@YulNaumenko YulNaumenko mentioned this pull request Sep 28, 2021
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Sep 28, 2021
@YulNaumenko
[Alerting] Fixed Jest test suites with unhandled promise rejections (e…
514169e 
…lastic#113213)

* [Alerting] Fixed Jest test suites with unhandled promise rejections

* fixed typecheck
YulNaumenko added a commit that referenced this pull request Sep 28, 2021
@YulNaumenko
[Alerting] Fixed Jest test suites with unhandled promise rejections (#…
bc432e3 
…113213) (#113310)

* [Alerting] Fixed Jest test suites with unhandled promise rejections

* fixed typecheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Jest test suites with unhandled promise rejections
5 participants
@YulNaumenko @elasticmachine @kibanamachine @chrisronline @ymao1