-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Host Risk metadata data to alerts flyout #113274
Conversation
52602fb
to
d32202e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned inline, there appears to be a lot of duplicated logic between this branch and the code added in https://github.com/elastic/kibana/pull/109553/files; I think we need a pass here to ensure we're not reinventing the wheel. @ecezalp or I should be able to help as needed.
Additionally, we've just added https://github.com/elastic/security-team/issues/1785 to address the current lack of space awareness in the host risk pipeline; the changes described there are going to need to happen here, as well (namely: replacing RISKY_HOSTS_INDEX
with a space-aware equivalent).
...plugins/security_solution/public/timelines/containers/host_risk_score/use_host_risk_score.ts
Outdated
Show resolved
Hide resolved
859f75b
to
ffd7534
Compare
Updates to text styles, padding, and margins moved for 8.1 -> https://github.com/elastic/security-team/issues/1764 |
698683b
to
84c5616
Compare
x-pack/plugins/security_solution/public/common/components/event_details/alert_summary_view.tsx
Outdated
Show resolved
Hide resolved
Thank you Angela! The Design team is aware and I am waiting for an alternative UI for this tooltip. Tagging @monina-n |
As suggested by Angela here elastic#113274 (comment)
2994a5b
to
7e27b6f
Compare
...solution/public/overview/components/overview_risky_host_links/risky_hosts_enabled_module.tsx
Show resolved
Hide resolved
Issue fixed by this commit: 4a18a9d |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @machadoum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on turning this around quickly. Thank you for updating the tests to be in react testing library. LGTM! 🚀 🎸
* Filter out empty values from alert flyout overview * Add Host Risk metadata data to alerts flyout * Add feature flag to host risk data query * Swap investigation guide and enrichment data places in the UI * Migrate alert_summary_view.test to react testing library * Refactor threat summary by extracting components and renaming
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Filter out empty values from alert flyout overview * Add Host Risk metadata data to alerts flyout * Add feature flag to host risk data query * Swap investigation guide and enrichment data places in the UI * Migrate alert_summary_view.test to react testing library * Refactor threat summary by extracting components and renaming Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Summary
issue: https://github.com/elastic/security-team/issues/1309
How to test Host risk data:
Log into the security app and visit the alert pages and open the flyout for an alert. It shouldn't display the host risk data panel.
Enable the feature flag and check it again. It should display the panel and show that there is no data for the host. Add
xpack.securitySolution.enableExperimental: ['riskyHostsEnabled']
tokibana.dev.yml
if you are using a custom
.siem-signals
index as per yourkibana.dev.yml
, run the following reindex query to obtain a.siem-signals-default-*
indexnote: this step is required for properly loading
Drilldown of Host Risk Score
dashboard, as it looks for the index pattern.siem-signals-default-*
Create default .siem-signals index
Create ml_host_risk_score_latest index
Add data to ml_host_risk_score_latest index (please replace {MY-HOST-NAME} by a valid hostname)
Create ml_host_risk_score index
Create an index pattern in Kibana / Stack Management / Index Patterns. The name of the id pattern should be
ml-host-risk-score-index-pattern
, and it should point toml_host_risk_score
Open the flyout for an event with the same hostname as the document you added to
ml_host_risk_score_latest
{MY-HOST-NAME}How to test Threat Summary new design
filebeat modules enable threatintel
https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-module-threatintel.htmlIndicator Match
rule and map one threat intel field.Remaining items todo
Checklist
Delete any items that are not applicable to this PR.