-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documents es/so/server deprecated settings removal in breaking changes #113337
Documents es/so/server deprecated settings removal in breaking changes #113337
Conversation
Pinging @elastic/kibana-core (Team:Core) |
=== `elasticsearch.preserveHost` is no longer valid | ||
*Details:* The deprecated `elasticsearch.preserveHost` setting in the `kibana.yml` file has been removed. | ||
|
||
*Impact:* Configure {kibana-ref}/settings.html#elasticsearch-requestHeadersWhitelist[`elasticsearch.requestHeadersWhitelist`] to whitelist client-side headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I know the term is used in the setting name anyway, but we may still want to use another term than whitelist in the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are on hold with this effort for the public API. Aren't we? #71398 (comment)
Anyway, it's too late to deprecate them for v8.0
. We can postpone this work until after 8.0. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it's too late. I was just asking if it would make sense to use another term in the details
section's description. But that's probably not worth it given that the same term is used in the setting's name anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and get this in, then we can revisit it once all the deprecations are handled (removed).
Adds docs for #113173.
Related to #103915
Screen shots (docs)
In breaking changes in 8.0:
To reviewers:
I tried to find alternative settings for each of these but hit a dead-end for
savedObjects.indexCheckTimeout
andserver.xsrf.token
during the platform migration.The semi-alternative setting for
elasticsearch.preserveHost
comes from #17237 (comment)Checklist