[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

XavierM · 2021-09-30T20:42:23Z

Summary

We rename the plugins.home.featureCatalogue.registerSolution({id to a new ID like that kibana core is not controlling the magic to hide/show the security solution app dependently of its privileges. Since we have different applications under the same application id like cases, security( management, timelines etc ...) with different privileges like cases and security.

#112980 (review)

One thing I did notice that is slightly different behavior than before is that a user can have cases read or all and not have security and they will not be able to access cases because the entire security plugin will be disabled.

This is slightly different from how it worked as a sub feature because it was not possible to grant cases privileges when the security privilege was set to none

The toggle is grayed out:

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-09-30T20:42:25Z

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

elasticmachine · 2021-09-30T20:42:25Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

...rity_solution/public/detections/containers/detection_engine/alerts/use_cases_from_alerts.tsx

x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx

x-pack/plugins/security_solution/public/cases/components/create/index.tsx

x-pack/plugins/security_solution/public/cases/pages/configure_cases.tsx

x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts

x-pack/plugins/security_solution/public/index.tsx

…ture

x-pack/plugins/security_solution/public/app/home/template_wrapper/index.tsx

…ses-top-feature

…ture

semd

tested locally and everything LGTM!
Thanks Xavier

XavierM · 2021-10-25T15:04:06Z

@elasticmachine merge upstream

kibanamachine · 2021-10-25T19:16:51Z

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2778	2779	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.6MB	4.5MB	-147.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	104.3KB	253.1KB	+148.8KB

Unknown metric groups

async chunk count

id	before	after	diff
`securitySolution`	22	20	-2

History

💛 Build #1093 was flaky 2953dce
💔 Build #1062 failed 0fd969a
💔 Build #948 failed 3548d79
💔 Build #910 failed bc24a21
💔 Build #859 failed 11e89a3
💔 Build #673 failed d4c87a5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tylersmalley

Not going to block this change on the limit increase, but I would please ask that you address the massive plugin bundle size. #95870

kibanamachine · 2021-10-27T22:23:22Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113573 or prevent reminders by adding the backport:skip label.

## Summary Small fixes and just a few docs to clarify things. I might be wrong on what I'm doing, so please let me know. Looking at the telemetry data from servers I see things like this (I made this up, not real data, but the shape of the data is the same as what we see on the servers): ```json "securitySolution:overview" : { "clicks_total" : 420, "minutes_on_screen_total" : 55.58454999999998, "viewId" : "main", "clicks_7_days" : 0, "clicks_90_days" : 0, "appId" : "securitySolution:overview", "minutes_on_screen_7_days" : 0, "minutes_on_screen_30_days" : 0, "clicks_30_days" : 0, "minutes_on_screen_90_days" : 0 }, ``` and I also see the views which is 👍 what I would make the dashboards from ... So not for sure if the structure above this is legacy. I could not get the shape of data above to happen locally. However, this shape below seems better and what I would create dashboards from. ```json "securitySolution" : { "clicks_total" : 420, "minutes_on_screen_total" : 2.90670000000006, "viewId" : "main", "clicks_7_days" : 70, "clicks_90_days" : 370, "appId" : "securitySolution", "minutes_on_screen_7_days" : 104.62756666666667, "minutes_on_screen_30_days" : 121.61288333333334, "clicks_30_days" : 121, "minutes_on_screen_90_days" : 250.55426666666665, "views" : [ { "clicks_total" : 8, "minutes_on_screen_total" : 5.709183333333334, "viewId" : "overview", "clicks_7_days" : 0, "clicks_90_days" : 6, "appId" : "securitySolution", "minutes_on_screen_7_days" : 0, "minutes_on_screen_30_days" : 0.5038833333333333, "clicks_30_days" : 0, "minutes_on_screen_90_days" : 6.565383333333333 }, ``` With this new key of "securitySolutionUI" I don't see keys like `securitySolutionUI:overview` but I do see the views like above so let me know if changing the keys here in some areas are a mistake or not or if this is not the right thing to do. Ref to earlier PR with the new key of `securitySolutionUI` from `APP_ID` changing: #113573

## Summary Fixes elastic/kibana-team#1136 The Kibana feature definition for Security Solution was missing the correct plugin ID registered in the `app` definition. We were still defining the old _"securitySolution"_ app ID in the `app` property, instead of the new _"securitySolutionUI"_ ID. The Security Solution plugin ID change (_"securitySolution"_ -> _"securitySolutionUI"_) was done a long time ago, the inconsistency with the Security feature definition is causing the _Security_ app to still be visible in the global search when the Security feature is disabled: - In the role features <img width="737" alt="Security and Cases disabled" src="https://github.com/user-attachments/assets/146b8205-90f7-4218-9f1a-7b55c3bad563"> - Or in the space features config <img width="1213" alt="Captura de pantalla 2024-09-03 a les 15 31 09" src="https://github.com/user-attachments/assets/2563675a-d956-4422-a887-d6d95bcad773"> This is fixed now: Before: <img width="1302" alt="Security app incorrectly enabled" src="https://github.com/user-attachments/assets/8031f054-7cfb-4098-93c2-eac402501887"> After: <img width="1302" alt="Security app disabled properly" src="https://github.com/user-attachments/assets/a4f38ec2-fb78-4b1b-8c2d-bac58b97ff99"> ### Caveat As per this PR changes: #113573 In the Kibana features of the role, under the Security catalog, both Security and Cases features need to be `none` for the Security Solution plugin to be disabled. Otherwise, we must enable the plugin and make the enabled features available. So, with a role with the following Kibana features: <img width="737" alt="Security disabled cases enabled" src="https://github.com/user-attachments/assets/aca8288e-9dd9-49d0-b864-e60273d30759"> The Security app needs to be available and display only Cases available: <img width="247" alt="navigation with only cases" src="https://github.com/user-attachments/assets/d4866edb-1d1d-4290-a399-76a37536b05c"> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

## Summary Fixes elastic/kibana-team#1136 The Kibana feature definition for Security Solution was missing the correct plugin ID registered in the `app` definition. We were still defining the old _"securitySolution"_ app ID in the `app` property, instead of the new _"securitySolutionUI"_ ID. The Security Solution plugin ID change (_"securitySolution"_ -> _"securitySolutionUI"_) was done a long time ago, the inconsistency with the Security feature definition is causing the _Security_ app to still be visible in the global search when the Security feature is disabled: - In the role features <img width="737" alt="Security and Cases disabled" src="https://github.com/user-attachments/assets/146b8205-90f7-4218-9f1a-7b55c3bad563"> - Or in the space features config <img width="1213" alt="Captura de pantalla 2024-09-03 a les 15 31 09" src="https://github.com/user-attachments/assets/2563675a-d956-4422-a887-d6d95bcad773"> This is fixed now: Before: <img width="1302" alt="Security app incorrectly enabled" src="https://github.com/user-attachments/assets/8031f054-7cfb-4098-93c2-eac402501887"> After: <img width="1302" alt="Security app disabled properly" src="https://github.com/user-attachments/assets/a4f38ec2-fb78-4b1b-8c2d-bac58b97ff99"> ### Caveat As per this PR changes: elastic#113573 In the Kibana features of the role, under the Security catalog, both Security and Cases features need to be `none` for the Security Solution plugin to be disabled. Otherwise, we must enable the plugin and make the enabled features available. So, with a role with the following Kibana features: <img width="737" alt="Security disabled cases enabled" src="https://github.com/user-attachments/assets/aca8288e-9dd9-49d0-b864-e60273d30759"> The Security app needs to be available and display only Cases available: <img width="247" alt="navigation with only cases" src="https://github.com/user-attachments/assets/d4866edb-1d1d-4290-a399-76a37536b05c"> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit e373e44)

allow case to itself when security solutions privileges is none

7b2ce23

XavierM added bug Fixes for quality problems that affect the customer experience release_note:enhancement v8.0.0 Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Cases labels Sep 30, 2021

XavierM requested review from a team as code owners September 30, 2021 20:42

XavierM requested review from ashokaditya and paul-tavares September 30, 2021 20:42

XavierM requested review from jonathan-buttner and semd September 30, 2021 21:30

semd reviewed Oct 1, 2021

View reviewed changes

...rity_solution/public/detections/containers/detection_engine/alerts/use_cases_from_alerts.tsx Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jonathan-buttner reviewed Oct 1, 2021

View reviewed changes

jportner mentioned this pull request Oct 14, 2021

[Meta] Platform Security team - 8.0 upgrade work #111160

Closed

XavierM added 3 commits October 14, 2021 11:04

Merge branch 'master' of github.com:elastic/kibana into cases-top-fea…

60609ba

…ture

bring back the right owner for cases

ddeb0b7

bring no privilege msg when needed it

dc8e77f

XavierM force-pushed the cases-top-feature branch from 805b60b to dc8e77f Compare October 15, 2021 13:14

XavierM added 2 commits October 15, 2021 09:23

Merge branch 'master' of github.com:elastic/kibana into cases-top-fea…

0081e9f

…ture

fix types

e950051

XavierM mentioned this pull request Oct 15, 2021

[Security Solution] Make new Add Data page more fine grained #115016

Merged

2 tasks

XavierM changed the title ~~[SECURITY SOLUTION] [CASES} Allow cases to be there when security solutions privileges is none~~ [SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none Oct 15, 2021

fix test

dd2fa10

This comment has been minimized.

Sign in to view

XavierM commented Oct 15, 2021

View reviewed changes

x-pack/plugins/security_solution/public/app/home/template_wrapper/index.tsx Outdated Show resolved Hide resolved

adding test

44d54b2

XavierM added 5 commits October 21, 2021 12:27

fix home link

74a3871

Merge branch 'cases-top-feature' of github.com:XavierM/kibana into ca…

516a654

…ses-top-feature

fix unit test

1dcccff

add test

d6cce9d

Merge branch 'master' of github.com:elastic/kibana into cases-top-fea…

0fd969a

…ture

XavierM requested a review from a team as a code owner October 21, 2021 17:25

XavierM added 2 commits October 21, 2021 14:38

fix telemetry

ce015c9

Merge branch 'master' of github.com:elastic/kibana into cases-top-fea…

2953dce

…ture

XavierM requested a review from a team as a code owner October 21, 2021 18:38

pgayvallet approved these changes Oct 25, 2021

View reviewed changes

semd approved these changes Oct 25, 2021

View reviewed changes

Merge branch 'master' into cases-top-feature

401ba0f

XavierM enabled auto-merge (squash) October 25, 2021 17:50

tylersmalley approved these changes Oct 25, 2021

View reviewed changes

XavierM merged commit 436c74a into elastic:master Oct 25, 2021

semd mentioned this pull request Oct 26, 2021

[Security Solutions] Improve deep links generation by capabilities #116274

Merged

1 task

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 27, 2021

cnasikas added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 28, 2021

FrankHassanabad mentioned this pull request Mar 3, 2022

[Security Solutions] Small telemetry fixes #126831

Merged

semd mentioned this pull request Sep 3, 2024

[Security Solution] Fix the feature app list #191965

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

XavierM commented Sep 30, 2021 •

edited

Loading

elasticmachine commented Sep 30, 2021

elasticmachine commented Sep 30, 2021

This comment has been minimized.

This comment has been minimized.

semd left a comment

XavierM commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

async chunk count

tylersmalley left a comment

kibanamachine commented Oct 27, 2021

[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

Conversation

XavierM commented Sep 30, 2021 • edited Loading

Summary

Checklist

elasticmachine commented Sep 30, 2021

elasticmachine commented Sep 30, 2021

This comment has been minimized.

This comment has been minimized.

semd left a comment

Choose a reason for hiding this comment

XavierM commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

tylersmalley left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 27, 2021

XavierM commented Sep 30, 2021 •

edited

Loading