Move reporting job types to /common #114400

vadimkibana · 2021-10-08T21:59:20Z

Summary

Closes #107085

Moves job param types to /common folder.
Re-exports job param types on browser and server.
Makes reporting example use JobParamsPDFV2 type.
Makes canvas use JobParamsPDFV2 type.

For maintainers

This was checked for breaking API changes and was labeled appropriately

vadimkibana · 2021-10-11T08:41:28Z

@elasticmachine merge upstream

kibanamachine · 2021-10-11T10:45:53Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`reporting`	134	156	+22

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.0MB	1.0MB	+30.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`reporting`	12	14	+2

Unknown metric groups

API count

id	before	after	diff
`reporting`	135	159	+24

History

💚 Build #159288 succeeded 39b0295
💔 Build #159287 failed 1866472
💔 Build #159269 failed 5eced7f
💔 Build #159266 failed e76433f
💔 Build #159263 failed 3c00e25

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan

We should make sure the types are not requiring the apps to provide info that Reporting can get internally.

x-pack/examples/reporting_example/public/components/app.tsx

crob611

Presentation Changes LGTM

…types

vadimkibana · 2021-11-02T15:24:13Z

@elasticmachine merge upstream

kibanamachine · 2021-11-02T17:17:57Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`reporting`	136	160	+24

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`reporting`	13	15	+2

Unknown metric groups

API count

id	before	after	diff
`reporting`	137	163	+26

History

💚 Build #2487 succeeded 4d20b6d
💔 Build #2422 failed e1bbf70
💔 Build #2392 failed 4c5fd88

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan

LGTM

It looks like there is an unused FakeRequest interface in x-pack/plugins/reporting/common/types/export_types/csv_searchsource_immediate.ts - it stood out to me because "immediate" export uses the live request, not a reconstructed one.

I'm OK with addressing that cleanup later.

kibanamachine · 2021-11-03T17:43:30Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.1.0

If any of these should not be on your pull request, please manually remove them.

* move pdf types to /common folder * move pdf v2 types to /common folder * move png v2 types to /common folder * move png types to /common * move csv_searchsource_immediate types to /common * move csv_searchsource type sto /common * move csv types to /common folder * export job params types on server and client * use JobParamsPDF in example app * use JobParamsPDFV2 in Canvas * dont export twice * export JobId * improve export syntax * update jest snapshot * fix imports * add JobAppParamsPDFV2 type * add JobAppParamsPDF type * update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-11-03T17:46:24Z

💔 Backport failed

Status	Branch	Result
✅	8.0
❌	7.16	Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 114400

* move pdf types to /common folder * move pdf v2 types to /common folder * move png v2 types to /common folder * move png types to /common * move csv_searchsource_immediate types to /common * move csv_searchsource type sto /common * move csv types to /common folder * export job params types on server and client * use JobParamsPDF in example app * use JobParamsPDFV2 in Canvas * dont export twice * export JobId * improve export syntax * update jest snapshot * fix imports * add JobAppParamsPDFV2 type * add JobAppParamsPDF type * update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>

* move pdf types to /common folder * move pdf v2 types to /common folder * move png v2 types to /common folder * move png types to /common * move csv_searchsource_immediate types to /common * move csv_searchsource type sto /common * move csv types to /common folder * export job params types on server and client * use JobParamsPDF in example app * use JobParamsPDFV2 in Canvas * dont export twice * export JobId * improve export syntax * update jest snapshot * fix imports * add JobAppParamsPDFV2 type * add JobAppParamsPDF type * update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/reporting/common/types/export_types/csv.ts # x-pack/plugins/reporting/server/index.ts

tsullivan · 2021-11-29T17:57:45Z

I saw that the attempted backport to 7.16 was not completed due to conflicts. So I put together this re-attempt: #119870

* Move reporting job types to /common (#114400) * move pdf types to /common folder * move pdf v2 types to /common folder * move png v2 types to /common folder * move png types to /common * move csv_searchsource_immediate types to /common * move csv_searchsource type sto /common * move csv types to /common folder * export job params types on server and client * use JobParamsPDF in example app * use JobParamsPDFV2 in Canvas * dont export twice * export JobId * improve export syntax * update jest snapshot * fix imports * add JobAppParamsPDFV2 type * add JobAppParamsPDF type * update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/reporting/common/types/export_types/csv.ts # x-pack/plugins/reporting/server/index.ts * fix ts Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>

vadimkibana added 14 commits October 8, 2021 23:26

move pdf types to /common folder

c6186b1

move pdf v2 types to /common folder

8162a9a

move png v2 types to /common folder

cd437dc

move png types to /common

622852d

move csv_searchsource_immediate types to /common

8891b7f

move csv_searchsource type sto /common

5a46d61

move csv types to /common folder

e895824

export job params types on server and client

d474896

use JobParamsPDF in example app

2ab0ce0

use JobParamsPDFV2 in Canvas

3c00e25

dont export twice

e76433f

export JobId

5eced7f

improve export syntax

1866472

update jest snapshot

39b0295

vadimkibana marked this pull request as ready for review October 11, 2021 08:41

vadimkibana requested review from a team as code owners October 11, 2021 08:41

vadimkibana requested a review from tsullivan October 11, 2021 08:41

vadimkibana added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review Team:AppServicesUx v7.16.0 v8.0.0 labels Oct 11, 2021

Merge branch 'master' into reporting-common-types

b70e071

tsullivan reviewed Oct 11, 2021

View reviewed changes

x-pack/examples/reporting_example/public/components/app.tsx Outdated Show resolved Hide resolved

crob611 approved these changes Oct 12, 2021

View reviewed changes

vadimkibana added 4 commits October 28, 2021 11:11

Merge remote-tracking branch 'upstream/master' into reporting-common-…

4c5fd88

…types

fix imports

b02fd2a

add JobAppParamsPDFV2 type

4212ccc

add JobAppParamsPDF type

e1bbf70

vadimkibana requested a review from tsullivan October 28, 2021 11:09

update test snapshot

4d20b6d

Merge branch 'main' into reporting-common-types

7c6fc5c

tsullivan approved these changes Nov 2, 2021

View reviewed changes

vadimkibana added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 3, 2021

vadimkibana merged commit 0d0e17b into elastic:main Nov 3, 2021

kibanamachine added the v8.1.0 label Nov 3, 2021

kibanamachine mentioned this pull request Nov 3, 2021

[8.0] Move reporting job types to /common (#114400) #117388

Merged

vadimkibana removed the v7.16.0 label Nov 4, 2021

tsullivan added the v7.16.1 label Nov 29, 2021

tsullivan mentioned this pull request Nov 29, 2021

[7.16] Move reporting job types to /common (#114400) #119870

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move reporting job types to /common #114400

Move reporting job types to /common #114400

vadimkibana commented Oct 8, 2021 •

edited

Loading

vadimkibana commented Oct 11, 2021

kibanamachine commented Oct 11, 2021

API count

tsullivan left a comment

crob611 left a comment

vadimkibana commented Nov 2, 2021

kibanamachine commented Nov 2, 2021

API count

tsullivan left a comment

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

tsullivan commented Nov 29, 2021

Move reporting job types to /common #114400

Move reporting job types to /common #114400

Conversation

vadimkibana commented Oct 8, 2021 • edited Loading

Summary

For maintainers

vadimkibana commented Oct 11, 2021

kibanamachine commented Oct 11, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

tsullivan left a comment

Choose a reason for hiding this comment

crob611 left a comment

Choose a reason for hiding this comment

vadimkibana commented Nov 2, 2021

kibanamachine commented Nov 2, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

History

tsullivan left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

💔 Backport failed

tsullivan commented Nov 29, 2021

vadimkibana commented Oct 8, 2021 •

edited

Loading