-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Series for Time Series Visual Builder #11496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins test this |
simianhacker
added
Feature:TSVB
TSVB (Time Series Visual Builder)
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
review
v5.5.0
v6.0.0
labels
Apr 28, 2017
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful addition!
I have a few minor UI feedback comments.
- Is it possible to hide the "Group By"-section when selecting Static Value? I don't immediately see the use of splitting up these threshold visualization
- When 'static value' is selected, I'd consider changing the defaults of the Options. When creating a threshold, I'd expect that most users will nearly always need to change the following options.
- Stacked:
stacked
(because we don't want to blend colors) - Point Size:
0
(because we don't need to see individual data points)
- Stacked:
simianhacker
added a commit
that referenced
this pull request
May 8, 2017
* Adding ability to add static value to Time Series Visual Builder * Fixing tests
Backported to 5.x with 4926ec8 |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* Adding ability to add static value to Time Series Visual Builder * Fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:TSVB
TSVB (Time Series Visual Builder)
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
release_note:enhancement
review
v5.5.0
v6.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define a static line on a chart. This can be used to add a threshold marker. You can also stack these series and create threshold backgrounds. In the image below I added 2 static values 1 at 0.3 and one at 0.1. Then I removed the lines, filled the series and stack only the two static lines. This creates the effect of background colors (or thresholds)