Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Series for Time Series Visual Builder #11496

Merged
merged 3 commits into from
May 8, 2017

Conversation

simianhacker
Copy link
Member

This PR adds the ability to define a static line on a chart. This can be used to add a threshold marker. You can also stack these series and create threshold backgrounds. In the image below I added 2 static values 1 at 0.3 and one at 0.1. Then I removed the lines, filled the series and stack only the two static lines. This creates the effect of background colors (or thresholds)

image

@simianhacker
Copy link
Member Author

Jenkins test this

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.5.0 v6.0.0 labels Apr 28, 2017
@thomasneirynck
Copy link
Contributor

jenkins, test this

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful addition!

I have a few minor UI feedback comments.

  • Is it possible to hide the "Group By"-section when selecting Static Value? I don't immediately see the use of splitting up these threshold visualization

image

  • When 'static value' is selected, I'd consider changing the defaults of the Options. When creating a threshold, I'd expect that most users will nearly always need to change the following options.
    • Stacked: stacked (because we don't want to blend colors)
    • Point Size: 0 (because we don't need to see individual data points)

@simianhacker simianhacker merged commit 08cbcb7 into elastic:master May 8, 2017
@simianhacker simianhacker deleted the tsvb-static-line branch May 8, 2017 19:31
simianhacker added a commit that referenced this pull request May 8, 2017
* Adding ability to add static value to Time Series Visual Builder

* Fixing tests
@simianhacker
Copy link
Member Author

Backported to 5.x with 4926ec8

snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
* Adding ability to add static value to Time Series Visual Builder

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement review v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants