Add .aggregate() function to timelion #11556
Merged
+133
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbragin
added
Feature:Visualizations
ppisljar
reviewed
May 3, 2017
| import _ from 'lodash'; | ||
|
|
||
| module.exports = function (points) { | ||
| return _.first(points); |
There was a problem hiding this comment.
do we really need a wrapper around lodash ? we use it directly everywhere else in our codebase ? (goes for this, min, max, sum, last)
|
maybe add |
|
@thomasneirynck Did you still want to review this? I'd like to get it merge for 5.5 |
thomasneirynck
approved these changes
May 11, 2017
| max: require('./max'), | ||
| last: require('./last'), | ||
| first: require('./first'), | ||
| sum: require('./sum') |
There was a problem hiding this comment.
similar comment as @ppisljar. Why not just inline the implementations here?
There was a problem hiding this comment.
They're separate because I reuse them in a function I haven't submitted a pull for yet: https://github.com/rashidkpc/timelion-extras/blob/master/functions/orderby/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of
.aggregate()is to reduce the set of points in a series to a single, static, value. This is especially useful for things like usingaggregate(first)for calculating growth since inception of stocks