fix duplicate chart title #11594
Merged
fix duplicate chart title #11594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Visualizations
kobelb
approved these changes
May 8, 2017
kobelb
reviewed
May 8, 2017
| @@ -79,7 +79,7 @@ export function VislibLibLayoutLayoutProvider(Private) { | |||
| const width = el.width(); | |||
| const height = el.height(); | |||
| axis.destroy(); | |||
| el.find('.chart-title svg').remove(); | |||
| $(this.el).find('.chart-title svg').remove(); | |||
There was a problem hiding this comment.
Having a this.el and a el referring to different elements makes this code-block slightly hard to understand. Perhaps renaming el to axisEl or something more descriptive would make this easier to understand?
ppisljar
force-pushed
the
fix/duplicateChartTitle
branch
from
27c4d19 to
9e23d4b
Compare
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
May 10, 2017
* fix duplicate chart title * updating el to axisWrapperElement
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
May 10, 2017
* fix duplicate chart title * updating el to axisWrapperElement
ppisljar
added a commit
that referenced
this pull request
May 10, 2017
ppisljar
added a commit
that referenced
this pull request
May 10, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* fix duplicate chart title * updating el to axisWrapperElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11512
Summary: fixes an error where point series would render duplicate chart titles when splitting chart by rows
closes