Show bucket size for Time Series Visual Builder on X-Axis #11639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
thomasneirynck
approved these changes
May 12, 2017
| y: 'years' | ||
| }; | ||
| export function getAxisLabelString(interval) { | ||
| const units = _.pluck(_.clone(relativeOptions).reverse(), 'value') |
There was a problem hiding this comment.
There's some duplication of this. units is a global constant, and we also use it in parse_relative_parts.js.
I would extract the units-array and the unitLookup-map to a different module, and pull it in where needed. E.g. add the units-array and the lookup table to the time_units module.
There was a problem hiding this comment.
The painful part of trying to use time_units.js is that it's setting a constant for Angular and the code that uses this is in React.
simianhacker
added a commit
that referenced
this pull request
May 17, 2017
* Adding seconds to the timeseries tooltip * Adding x-axis label to show the bucket size
|
Backported to 5.x with 98de700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an x-axis label to the Time Series visualization for the Time Series Visual Builder that displays the interval size. For something with 10000 milliseconds it will display 'per 10 seconds'. This also changes the date format of the tooltip to display seconds.
Before:
After: