[UI Framework] Improve navigability of the docs #11666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! Great addition. |
ycombinator
approved these changes
May 9, 2017
| this.onSearchChange = this.onSearchChange.bind(this); | ||
| } | ||
|
|
||
| onSearchChange(event) { |
There was a problem hiding this comment.
I think if you redefine this as onSearchChange = (event) => { you can get rid of the this binding in the constructor. Personally I've found this style more readable.
There was a problem hiding this comment.
I tried it out and got a syntax error. I don't think it's valid ES6 class syntax? 🍂
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 9, 2017
* Add search to navigation. * Add pagination buttons to UI Framework header.
cjcenizal
added a commit
that referenced
this pull request
May 9, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* Add search to navigation. * Add pagination buttons to UI Framework header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds search and pagination to the UI Framework. Addresses #11574.