Add new config option to control the amount of items in listing pages #11674

trevan · 2017-05-09T17:36:23Z

This increases the default limit on the visualization and dashboard listing page to 1000 while also making it configurable.

The text is really rough and needs to be polished.

Add a warning message when the limit is reached.

elasticmachine · 2017-05-09T17:36:26Z

Can one of the admins verify this patch?

thomasneirynck · 2017-05-10T14:57:48Z

jenkins, test this

thomasneirynck

thanks @trevan!

I think this is a useful shot-term solution until we get proper pagination for this.

@stacey-gammon, what do you think?

thomasneirynck · 2017-05-12T19:59:05Z

src/core_plugins/kibana/public/visualize/listing/visualize_listing.html

+    <div class="kuiInfoPanel kuiInfoPanel--warning">
+      <div class="kuiInfoPanelBody">
+        <div class="kuiInfoPanelBody__message">
+          The number of matching visualizations ({{ listingController.totalItems }}) is larger than the listing limit {{ listingController.listingLimit }}. Sorting will only work for the first {{ listingController.listingLimit }} visualizations. To see more, either filter the list or increase the config savedObjects:listingLimit.


wrt

Sorting will only work for the first {{ listingController.listingLimit }} visualizations

imho, I would just strip this. i feel like the more detailed the error message is here, the more convoluted it gets for the reader. The first sentence and last are on the nose though.

stacey-gammon · 2017-05-12T20:30:01Z

Code looks good, I second what @thomasneirynck said about the message though, I think shorter would be better.

Only thought I have is whether we should put it in the SavedObjectLoader directly, instead of just the dashboard and visualize landing pages, so saved object management can take advantage of it as well. If we do that though, I'd just want to be sure that increasing the limit to 1k doesn't affect the performance of the saved object management page, since it has all types of items listed in that table. Even so, I suspect it wouldn't be a problem.

But we can always investigate this as a second step, since at least this solves the problem for the landing pages.

stacey-gammon · 2017-05-12T21:09:52Z

Actually, I took a closer look at the saved object management page and it has no pagination, it just lists the first 100 visualizations, so introducing it in there would be more work, so I'm fine with this PR going in as is, with just the listing pages using it.

I'm not 100% sure about the UI. Our pagers and the warnings are now inconsistent. With this PR it looks like this:

While the other pager we have looks like this:

The benefit of the first is that it's more informative, but the benefit of the second is that it's concise and subtle.

@cjcenizal @snide Any recommendations here?

thomasneirynck · 2017-05-12T21:14:26Z

@stacey-gammon: fyi, we have another issue that tracks this similar issue for the Saved Object list: #8044

trevan · 2017-05-13T20:01:21Z

So, I'm trying to figure out what changes are wanted. It seams like I need to change the text (which I expected) but maybe you want me to have the text next to the pagination element? I'm fine with that change, though I would want this message to always be shown unlike with the discover tables. This is because the limit affects the table before you get to the end of the list because of sorting.

stacey-gammon · 2017-05-15T10:40:34Z

@trevan - I'm waiting to see what feedback the design team (@cjcenizal @snide @alt74) comes back with regarding the placement of the error, error text, and when it should be shown, as they have the final say.

One idea I had for the sort warning was a small warning icon in the header row - maybe all the way to the right, or maybe in the column that is currently being sorted on (show the text on hover). And then maybe we can keep the 'limited results' warning to match the other table.

cjcenizal · 2017-05-16T17:01:41Z

This design looks good to me. I'd refine the copy to be:

You have 201 visualizations, but your "listingLimit" setting prevents the table below from displaying more than 5. You can change this setting under Management > Advanced Settings.

trevan · 2017-05-19T16:10:41Z

@cjcenizal, is that the change I should make or should I wait for more input?

stacey-gammon

With the change in wording suggested by @cjcenizal, LGTM!

cjcenizal · 2017-05-19T16:28:56Z

@trevan Thanks for checking. I think we're OK to move forward with this change.

trevan · 2017-05-20T16:29:15Z

I've updated the message per @cjcenizal comment above

cjcenizal

Thanks for making that change @trevan! Sorry, I have one small request and then we can merge this.

cjcenizal · 2017-05-20T16:58:47Z

src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html

+    <div class="kuiInfoPanel kuiInfoPanel--warning">
+      <div class="kuiInfoPanelBody">
+        <div class="kuiInfoPanelBody__message">
+          You have {{ listingController.totalItems }} dashboards, but your "listingLimit" setting prevents the table below from displaying more than {{ listingController.listingLimit }}. You can change this setting under Management &gt; Advanced Settings.


I just realized we should probably just link directly to the Advanced Settings page. Can we change the last sentence to:

You can change this setting under <a kbn-href="#/management/kibana/settings" class="kuiLink">Advanced Settings</a>.

cjcenizal · 2017-05-20T17:00:55Z

jenkins, test this

trevan · 2017-05-20T17:47:14Z

@cjcenizal, done

cjcenizal · 2017-05-20T18:08:12Z

@trevan Thanks!

cjcenizal · 2017-05-20T18:08:17Z

jenkins, test this

…elastic#11674) * Add new config option to control the amount of items in listing pages * Add a warning message when the limit is reached.

…#11674) (#11945) * Add new config option to control the amount of items in listing pages * Add a warning message when the limit is reached.

…elastic#11674) * Add new config option to control the amount of items in listing pages * Add a warning message when the limit is reached.

Add new config option to control the amount of items in listing pages

e613dac

Add a warning message when the limit is reached.

thomasneirynck added :Sharing review v6.0.0 Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels May 10, 2017

thomasneirynck requested review from thomasneirynck and stacey-gammon May 12, 2017 15:50

thomasneirynck approved these changes May 12, 2017

View reviewed changes

thomasneirynck added release_note:enhancement v5.5.0 labels May 12, 2017

epixa added the v6.0.0-alpha2 label May 17, 2017

stacey-gammon approved these changes May 19, 2017

View reviewed changes

Update warning message per request

ea0ab30

cjcenizal approved these changes May 20, 2017

View reviewed changes

Add link to message

d554be4

cjcenizal merged commit 7557c8f into elastic:master May 21, 2017

cjcenizal mentioned this pull request May 21, 2017

[5.x] Add new config option to control the amount of items in listing pages (#11674) #11945

Merged

LeeDr mentioned this pull request May 23, 2017

After JSON import is complete, list of visualizations/dashboards/searches should auto refresh #10523

Closed

This was referenced Jun 2, 2017

Displayed total number of visualisations stops at 100 #12133

Closed

Kibana-5.4 Visualizations not showing beyond 100 #12166

Closed

trevan deleted the increase-listing-limit branch December 19, 2017 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new config option to control the amount of items in listing pages #11674

Add new config option to control the amount of items in listing pages #11674

trevan commented May 9, 2017

elasticmachine commented May 9, 2017

thomasneirynck commented May 10, 2017

thomasneirynck left a comment •

edited

Loading

thomasneirynck May 12, 2017 •

edited

Loading

stacey-gammon commented May 12, 2017

stacey-gammon commented May 12, 2017

thomasneirynck commented May 12, 2017

trevan commented May 13, 2017

stacey-gammon commented May 15, 2017

cjcenizal commented May 16, 2017

trevan commented May 19, 2017

stacey-gammon left a comment

cjcenizal commented May 19, 2017

trevan commented May 20, 2017

cjcenizal left a comment

cjcenizal May 20, 2017 •

edited

Loading

cjcenizal commented May 20, 2017

trevan commented May 20, 2017

cjcenizal commented May 20, 2017

cjcenizal commented May 20, 2017

Add new config option to control the amount of items in listing pages #11674

Add new config option to control the amount of items in listing pages #11674

Conversation

trevan commented May 9, 2017

elasticmachine commented May 9, 2017

thomasneirynck commented May 10, 2017

thomasneirynck left a comment • edited Loading

Choose a reason for hiding this comment

thomasneirynck May 12, 2017 • edited Loading

Choose a reason for hiding this comment

stacey-gammon commented May 12, 2017

stacey-gammon commented May 12, 2017

thomasneirynck commented May 12, 2017

trevan commented May 13, 2017

stacey-gammon commented May 15, 2017

cjcenizal commented May 16, 2017

trevan commented May 19, 2017

stacey-gammon left a comment

Choose a reason for hiding this comment

cjcenizal commented May 19, 2017

trevan commented May 20, 2017

cjcenizal left a comment

Choose a reason for hiding this comment

cjcenizal May 20, 2017 • edited Loading

Choose a reason for hiding this comment

cjcenizal commented May 20, 2017

trevan commented May 20, 2017

cjcenizal commented May 20, 2017

cjcenizal commented May 20, 2017

thomasneirynck left a comment •

edited

Loading

thomasneirynck May 12, 2017 •

edited

Loading

cjcenizal May 20, 2017 •

edited

Loading