Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused public code from share plugin #116905

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Oct 31, 2021

KibanaURL class is unused externally and so doesn't need to be exported as part of the Share plugins public API.

@stacey-gammon
Copy link
Contributor Author

buildkite, test this

@stacey-gammon stacey-gammon added chore technical debt Improvement of the software architecture and operational architecture v8.1.0 labels Nov 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 66 65 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
share 90 84 -6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 54.2KB 53.8KB -383.0B
Unknown metric groups

API count

id before after diff
share 143 137 -6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon marked this pull request as ready for review November 1, 2021 14:43
@stacey-gammon stacey-gammon requested a review from a team as a code owner November 1, 2021 14:43
@stacey-gammon stacey-gammon added the release_note:skip Skip the PR/issue when compiling release notes label Nov 1, 2021
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@stacey-gammon stacey-gammon merged commit 47480cf into elastic:main Nov 2, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116905 or prevent reminders by adding the backport:skip label.

@stacey-gammon stacey-gammon added the backport:skip This commit does not require backporting label Nov 4, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants